danger-review
Passed Started
by
@psimyn
Simon Knox
1Running with gitlab-runner 16.3.0~beta.108.g2b6048b4 (2b6048b4)2 on blue-3.shared-gitlab-org.runners-manager.gitlab.com/default sUrYYgEG, system ID: s_35f98e2af4653 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_IMPROVED_URL_MASKING:true, FF_RESOLVE_FULL_TLS_CHAIN:false6Using Docker executor with image ruby:3.0 ...7Pulling docker image ruby:3.0 ...8Using docker image sha256:15e37249dbb531fbab91ef210aa3e0868985761e7a10b2cb2e964bf0158098a2 for ruby:3.0 with digest ruby@sha256:246a5061b30906feab28d77de7f00cfeb750ca0fa00fc02fba9b591cee780bb5 ...10Running on runner-suryygeg-project-7071551-concurrent-0 via runner-suryygeg-shared-gitlab-org-1695279043-e66359d9...12Fetching changes...13Initialized empty Git repository in /builds/gitlab-org/gitlab-ui/.git/14Created fresh repository.15Checking out 9e3cd1cc as detached HEAD (ref is refs/merge-requests/3612/train)...16Skipping Git submodules setup17$ git remote set-url origin "${CI_REPOSITORY_URL}"19Using docker image sha256:15e37249dbb531fbab91ef210aa3e0868985761e7a10b2cb2e964bf0158098a2 for ruby:3.0 with digest ruby@sha256:246a5061b30906feab28d77de7f00cfeb750ca0fa00fc02fba9b591cee780bb5 ...20$ [[ ! -f "Gemfile" ]] && bundle init && bundle add gitlab-dangerfiles --version "$GITLAB_DANGERFILES_VERSION"21Writing new Gemfile to /builds/gitlab-org/gitlab-ui/Gemfile22Fetching gem metadata from https://rubygems.org/..............23Resolving dependencies...24Fetching gem metadata from https://rubygems.org/...........25Fetching rake 13.0.626Installing rake 13.0.627Fetching base64 0.1.128Fetching public_suffix 5.0.329Installing base64 0.1.130Using bundler 2.2.3331Fetching claide 1.1.032Installing public_suffix 5.0.333Fetching colored2 3.1.234Installing claide 1.1.035Fetching nap 1.1.036Installing colored2 3.1.237Fetching open4 1.3.438Installing nap 1.1.039Fetching faraday-net_http 3.0.240Installing open4 1.3.441Fetching ruby2_keywords 0.0.542Installing faraday-net_http 3.0.243Fetching rchardet 1.8.044Installing ruby2_keywords 0.0.545Fetching rexml 3.2.646Installing rexml 3.2.647Installing rchardet 1.8.048Fetching no_proxy_fix 0.1.249Fetching unicode-display_width 2.4.250Installing no_proxy_fix 0.1.251Installing unicode-display_width 2.4.252Fetching mini_mime 1.1.553Fetching multi_xml 0.6.054Installing multi_xml 0.6.055Installing mini_mime 1.1.556Fetching addressable 2.8.557Fetching cork 0.3.058Installing cork 0.3.059Fetching faraday 2.7.1160Installing addressable 2.8.561Fetching kramdown 2.4.062Installing faraday 2.7.1163Fetching terminal-table 3.0.264Installing kramdown 2.4.065Installing terminal-table 3.0.266Fetching httparty 0.21.067Installing httparty 0.21.068Fetching claide-plugins 0.9.269Fetching git 1.18.070Installing claide-plugins 0.9.271Fetching faraday-http-cache 2.5.072Installing git 1.18.073Fetching sawyer 0.9.274Installing faraday-http-cache 2.5.075Fetching gitlab 4.19.076Installing sawyer 0.9.277Fetching kramdown-parser-gfm 1.1.078Installing gitlab 4.19.079Installing kramdown-parser-gfm 1.1.080Fetching octokit 6.1.181Installing octokit 6.1.182Fetching danger 9.3.283Installing danger 9.3.284Fetching danger-gitlab 8.0.085Installing danger-gitlab 8.0.086Fetching gitlab-dangerfiles 3.5.187Installing gitlab-dangerfiles 3.5.188$ [[ ! -f "Gemfile.lock" ]] || bundle config set --local frozen "true"89$ bundle install90Using rake 13.0.691Using public_suffix 5.0.392Using addressable 2.8.593Using base64 0.1.194Using bundler 2.2.3395Using claide 1.1.096Using colored2 3.1.297Using cork 0.3.098Using nap 1.1.099Using open4 1.3.4100Using claide-plugins 0.9.2101Using faraday-net_http 3.0.2102Using ruby2_keywords 0.0.5103Using faraday 2.7.11104Using faraday-http-cache 2.5.0105Using rchardet 1.8.0106Using git 1.18.0107Using rexml 3.2.6108Using kramdown 2.4.0109Using kramdown-parser-gfm 1.1.0110Using no_proxy_fix 0.1.2111Using sawyer 0.9.2112Using octokit 6.1.1113Using unicode-display_width 2.4.2114Using terminal-table 3.0.2115Using danger 9.3.2116Using mini_mime 1.1.5117Using multi_xml 0.6.0118Using httparty 0.21.0119Using gitlab 4.19.0120Using danger-gitlab 8.0.0121Using gitlab-dangerfiles 3.5.1122Bundle complete! 1 Gemfile dependency, 32 gems now installed.123Use `bundle info [gemname]` to see where a bundled gem is installed.124$ [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" ]] && git fetch "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" "$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME"125$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command126To use retry middleware with Faraday v2.0+, install `faraday-retry` gem127Importing rule changes_size at /usr/local/bundle/gems/gitlab-dangerfiles-3.5.1/lib/danger/rules/changes_size128Importing rule commits_counter at /usr/local/bundle/gems/gitlab-dangerfiles-3.5.1/lib/danger/rules/commits_counter129Importing rule semantic_commit at /builds/gitlab-org/gitlab-ui/danger/semantic_commit130Importing rule simple_roulette at /usr/local/bundle/gems/gitlab-dangerfiles-3.5.1/lib/danger/rules/simple_roulette131Importing rule simple_ux_review at /builds/gitlab-org/gitlab-ui/danger/simple_ux_review132Importing rule specs at /builds/gitlab-org/gitlab-ui/danger/specs133Importing rule subtype_label at /usr/local/bundle/gems/gitlab-dangerfiles-3.5.1/lib/danger/rules/subtype_label134Importing rule type_label at /usr/local/bundle/gems/gitlab-dangerfiles-3.5.1/lib/danger/rules/type_label135Importing rule z_add_labels at /usr/local/bundle/gems/gitlab-dangerfiles-3.5.1/lib/danger/rules/z_add_labels136Importing rule z_retry_link at /usr/local/bundle/gems/gitlab-dangerfiles-3.5.1/lib/danger/rules/z_retry_link137Results:138Markdown:139## 📦 Minor release ([conventional commits](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/commits.md))140This Merge Request will trigger a _minor release_ of GitLab UI, triggered by commit:1416de322c20f7fb2f2f7922392da513167f3bd2530142This will bump the second part of the version number, e.g. `v1.2.3` -> `v1.3.0`.143## Reviewer roulette144Changes that require review have been detected! A merge request is normally145reviewed by both a reviewer and a maintainer in its primary category and by a146maintainer in all other categories.147To spread load more evenly across eligible reviewers, Danger has picked a candidate for each148review slot. Feel free to149[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab-ui)150if you think someone else would be better-suited151or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.152To read more on how to use the reviewer roulette, please take a look at the153[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)154and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).155Please consider assigning a reviewer or maintainer who is a156[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab-development-kit) in the area of the merge request.157Once you've decided who will review this merge request, mention them as you158normally would! Danger does not automatically notify them for you.159| Category | Reviewer | Maintainer |160| -------- | -------- | ---------- |161| ~"frontend" | [Andrew Fontaine](https://gitlab.com/afontaine)  (`@afontaine`) (UTC-4, 6 hours behind `@seggenberger`) | [Scott de Jonge](https://gitlab.com/sdejonge)  (`@sdejonge`) (UTC+10, 8 hours ahead of `@seggenberger`) |162**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab-ui/-/jobs/5135134464) that generated this comment.**164Job succeeded