Button with icons have an extra space to the right

Screenshot

Technical Info

The css rule that creates the space is:

/* line 283, app/assets/stylesheets/framework/buttons.scss */
.btn svg:not(:last-child), .project-buttons .stat-text svg:not(:last-child),
.btn .fa:not(:last-child),
.project-buttons .stat-text .fa:not(:last-child) {
  margin-right: 5px;
}

You can see the effect in storybook by selecting "Include GitLab CSS bundle" https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-button--default

This was introduced by: !1365 (comment 338708327)

Original Discussion

The following discussion from !1365 (merged) should be addressed.