Skip to content

Cleanup temporarily skipped accessibility violations in storybook

As part of test(accessibility): leverage storybook test ru... (!4720 - merged)(#2959) we temporarily skipped violations with temporarySkipRules so that the tests could be used in pipelines.

Skipped rules need to be investigated in these files:

Still required:

  • src/components/base/accordion/accordion.stories.js
  • src/components/base/button/button.stories.js
  • src/components/base/dropdown/dropdown.stories.js
  • src/components/base/dropdown/dropdown_item.stories.js
  • src/components/base/filtered_search/filtered_search_suggestion.stories.js
  • src/components/base/filtered_search/filtered_search_suggestion_list.stories.js
  • src/components/base/filtered_search/filtered_search_term.stories.js
  • src/components/base/filtered_search/filtered_search_token.stories.js
  • src/components/base/filtered_search/filtered_search_token_segment.stories.js
  • src/components/base/form/form_fields/form_fields.stories.js
  • src/components/base/form/form_group/form_group.stories.js
  • src/components/base/form/form_input_group/form_input_group.stories.js
  • src/components/base/form/form_textarea/form_textarea.stories.js
  • src/components/base/infinite_scroll/infinite_scroll.stories.js
  • src/components/base/tabs/tabs/tabs.stories.js
  • src/components/base/token_selector/token_selector.stories.js

Should be able to be removed, but still reports low contrast:

Removable:

  • src/components/base/form/form_combobox/form_combobox.stories.js !5029 (merged)

Partially removable:

Fixed:

Follow steps in https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/accessibility_testing.md#handling-new-violations to resolve errors in the above files.

Edited by Scott de Jonge