Adjust GlBadge's icon size
In gitlab!78984 (comment 819095364), it was discovered that the currently implemented icon size in GlBadge
(always 16px) doesn't correspond to the designs in Pajamas.
Relatedly, it was also recently discovered that badge icons cause some alignment issues.
In Pajamas, the icon size seems to mostly be 12px, except the calendar icon is non-square and so is 14x12. Pipeline badges all seem to use 16px icons. In the GlBadge
implementation, the icon size is always 16px. In neither case do the icon sizes seem to vary with the badge's size.
Size | Image |
GlBadge implementation |
---|---|---|
12x12 (common?) | ||
14x12 (calendar icon only?) | ||
16x16 (pipeline badges only? |
Questions
- Should
GlBadge
be changed to use 12px icons by default?- Should certain icons, like the various pipeline icons, be special-cased to use 16px?
- What of the non-square icons, e.g.,
calendar
?
- Should the icon's size vary with the badge's size (as suggested in gitlab!78984 (comment 819095364))?
Implementation plan
-
Update GlBadge
-
Update gl_badge_tag
Edited by Mark Florian