Roulette doesn't take all eligible maintainers into account
According to the handbook, every frontend engineer is a reviewer of GitLab UI, but not all of then are marked as such in the team.yml
. Similarly, not all GitLab maintainers are marked as GitLab UI maintainers. This results in some discrepancies in the reviewers & maintainers lists between GitLab and GitLab UI, as can be seen in https://about.gitlab.com/handbook/engineering/projects/.
For this reason, the reviewers roulette currently pulls data from GitLab's team, which better represents the workforce, but it's not perfect either. For example, I'm myself a maintainer of GitLab UI, but not of GitLab, which means that the roulette still considers me as a reviewer.
Let's review the roulette's logic to improve the reliability of its picks.