Improve modal with tertiary icon button for close action
Summary
The modal component could be improved with a tertiary icon button for the close action. This will yield the result that the close action has a dedicated background upon interaction. This improves the intractability now that the tertiary button component is ready for use.
Steps to reproduce
- Open a modal at for example /feature_flags by pressing the configure feature flags button
- Hover the close
X
button in the top right corner - See almost no difference in visual interaction
Example Project
Open the configure feature flags modal at /feature_flags by pressing the configure feature flags button.
What is the current bug behavior?
See almost no difference in visual interaction
What is the expected correct behavior?
See a clear visual change upon interaction
Relevant logs and/or screenshots
gif of interaction with current close button of a modal |
---|
![]() |
Gif of visual change on interaction with tertiary buttons |
---|
![]() |
Output of checks
This bug happens on GitLab.com
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)