Add docker support for terminal
All threads resolved!
All threads resolved!
Compare changes
Files
6+ 35
− 0
@@ -5,32 +5,31 @@ import (
Add support of interactive web terminal for the docker
executor.
The following MR takes the simplistic approach on how to proxy the docker and the WebSocket. There is a more detailed approach at this branch which I am not sure if it is better or not.
If we go with this approach we can refactor the FileDescriptorProxy
and DockerProxy
to be a new ReadWriterProxy
but this will have backward incompatibility consequences, which might not be to much of an issue since we only have 1 consumer of this package thus far.
master
(if you do - rebase it please)Closes #3 (closed)