Skip to content

Add docker support for terminal

Steve Xuereb requested to merge 3-proxy-docker-connection into master

What does this MR do?

Add support of interactive web terminal for the docker executor.

Are there points in the code the reviewer needs to double check?

The following MR takes the simplistic approach on how to proxy the docker and the WebSocket. There is a more detailed approach at this branch which I am not sure if it is better or not.

If we go with this approach we can refactor the FileDescriptorProxy and DockerProxy to be a new ReadWriterProxy but this will have backward incompatibility consequences, which might not be to much of an issue since we only have 1 consumer of this package thus far.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

gitlab-runner#3467 (closed)

Closes #3 (closed)

Edited by Steve Xuereb

Merge request reports