This project is archived. Its data is read-only.
Icon > Add circular collapse
## Description The circular collapse icon is used on multiple occasions in our codebase. The styles are defined in `app/assets/stylesheets/framework/diffs.scss` and have the `diff-notes-collapse` and `diff-codequality-collapse` assigned to it. We need to come up with GitLab UI Vue component or a helper class to make these styles reusable. | screenshot | | ------ | |![Screenshot_2022-08-30_at_14.22.23](/uploads/092924ccdd46e77fe72c022474a5e1b0/Screenshot_2022-08-30_at_14.22.23.png)| How to reproduce screenshot: 1. make sure your GDK has an ultimate license 1. Feature.enable(:refactor_code_quality_inline_findings) 1. clone this project: https://gitlab.com/jannik_lehmann/code-quality-test 1. recreate this MR: http://gdk.test:3000/root/code-quality-test-index/-/merge_requests/1 1. run pipeline 1. See inline diffs in diff view of created MR ### Figma file <!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. --> [❖ View working file in Figma →](https://www.figma.com/file/h4YjjttHL5YI0mXZfQ4uuU/branch/2IcPknHKNb5K7fNZaFl3KR/GitLab-Product-Icons?node-id=0%3A1&viewport=745%2C528%2C1&t=ABtUgPhzXQdNl0LH-11) --- ## Checklists Make sure the following are completed before closing the issue: ### Assignee tasks: <details><summary>See tasks:</summary> 1. [x] Create a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the [GitLab Product Icons](https://www.figma.com/file/h4YjjttHL5YI0mXZfQ4uuU/GitLab-Product-Icons) when updating or creating an icon. - Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-new-icon-lvanc`. 1. [x] Update the link to the working file under the **Figma link** section above. 1. [ ] If work was not done in a branch (a merged branch will automatically be archived), move your working file to the shared Figma project: 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. 1. [x] When applicable, follow our [iconography][iconography] guidelines. 1. [ ] Ask a [Foundations designer][foundations-team] to review your design. - Ensure the designer that will be reviewing your file has edit permissions in Figma. </details> ### Reviewer tasks: <details><summary>See tasks:</summary> 1. [x] Review the icon in the author’s branch. Add design-specific comments in Figma to maintain context. Add general comments to this issue, including your approval status. 1. [x] Once review is approved, assign to a [Figma maintainer](https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com) for final review. </details> ### Maintainer tasks: <details><summary>See tasks:</summary> 1. [x] Merge the branch to the **GitLab Product Icons** file, convert the icon to a component, add keywords and usage notes (optional) in the description, and view it in the Assets panel to ensure it aligns with what’s outlined in the [document and asset library structure](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure) documentation. 1. [x] Publish the library changes along with a clear message about the update. </details> ### Library addition tasks: Once the Reviewer or Maintainer has approved your icon design, consider the following tasks to add the icon the `gitlab-svgs` library. <details><summary>See tasks:</summary> <!-- This checklist helps streamline the process of getting an icon from Figma to the library. --> 1. [ ] Create a new merge request (MR) from this issue. 1. [ ] Checkout the new branch locally. 1. [ ] Export the icon component from the Pajamas UI Kit (in Figma) to the **/sprite_icons** folder in your local instance of the repo. The file name should be lowercase, and use hyphens as a separator between terms. 1. [ ] Open the SVG you just exported in your code editor and remove `fill="none"` from the `<svg>` element. 1. [ ] In a terminal window, run `yarn run dev` to preview the SVG library locally. Find the new icon and test it out by changing settings in the **Icon configuration** panel of the site. The icon should change color and size with no issues. 1. [ ] After you’ve committed the changes and the pipeline passes, double-check your icon in the review app and test that it matches your expectations. 1. [ ] Assign the MR to be reviewed and merged by a [maintainer](https://about.gitlab.com/handbook/engineering/projects/#gitlab-svgs), and proceed with any changes. 1. [ ] Add a read only (FYI) agenda item to the next [UX weekly call](https://docs.google.com/document/d/1fSRyTboySDpWPrQiiFIcIOhg09-9G54haIippIVtcCY) to inform everyone of the new icon, linking to this issue. If you run into any problems, ensure that all other steps in the project [README](https://gitlab.com/gitlab-org/gitlab-svgs/-/blob/main/README.md) have been followed. </details> --- 1. [ ] 🎉 Congrats, you made it! You can now close this issue. ## Links / references <!-- Add external links and references if necessary --> [foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team [iconography]: https://design.gitlab.com/product-foundations/iconography [misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
issue