Several icons are made in a way that does not allow to change color
Thanks @samdbeckham for making me go down this
Apparently some of our SVG icons have a fixed fill, that does not allow their color to be changed with the help of the font-color.
A good check to see which icons are affected, you can simple set the foreground and background colors in gitlab svg to the same color. All icons should "disappear". Here are lists of icons that don't:
Green on Green | Green on normal | No Status Icons |
---|---|---|
![]() |
![]() |
![]() |
The only valid use case for the fill
property seem to be our status icons. This leaves us with the following icons.
Icon Name | Comment | MR that fixes it |
---|---|---|
canceled-circle | No usage in gitlab-ee found | !169 (merged) |
image-comment-dark | 5 usages. If we fix this, we probably need to add CSS colors to CE | !169 (merged) |
image-comment-light | No usage in gitlab-ee found | !169 (merged) |
information | 1 usage | !157 (merged) |
live-preview | 1 usage | !169 (merged) |
object | No usage found | N/A |
spinner | Seems to be unused, as we still use the font awesome spinner | N/A |
upload | 1 usage | !169 (merged) |
The hardest things seems the spinner
icon. All other icons should be rather straight-forward to fix.
Who in @gitlab-com/gitlab-ux could help with redrawing the icons?
(BTW what do we need canceled-circle
and object
for?)
Edited by Andy Volpe