Unify instantiation of command.Shell
The following discussion from !451 (merged) should be addressed:
-
@theoretick started a discussion: (+1 comment) You mentioned a TODO here, should we create a follow-up issue?
gitlab-shell and gitlab-sshd both need the code that's implemented as command[args].Shell
, but they instantiate instances of it differently. Ideally, we'd push all those differences out to the sshenv
struct being introduced in !451 (merged) and use the same initializer for both code paths. This would imply gitlab-sshd
faking an SSH_ORIGINAL_COMMAND
value, among other things.