Remove confusingly named VersionCheckCreatorService
Problem
After https://gitlab.com/gitlab-org/gitlab-services/version.gitlab.com/-/issues/37+ the following problem should be adressed (taken from https://gitlab.com/gitlab-org/gitlab-services/version.gitlab.com/-/issues/37#note_1694496410):
The only thing to consider is that we have a
VersionCheckCreatorService
. The name might be a little misleading, as we do not create VersionChecks any longer. I think the service can be removed in favor of doing the VersionCheck directly in the controller because everything just happens in-memory.
In addition the VersionCheckCreatorService is requiring data that we no longer need (e.g. referrer
), which leads to this data being required by the instance.
Desired Outcome
Version Check code doesn't include a confusingly named service and only requires data it actually needs to provide its service.
Proposal
Do the VersionCheck directly in the controller because everything just happens in-memory.
How to verify
Version check itself should behave as before towards the user