Loading
Commits on Source 10
-
Mark Florian authored
This is necessary for the *next* commit. In Vue 2 and Vue 3 modes, the `#storybook-root` and `.vue-component-mounted` selectors point to the same element. In hybrid Vue mode, the first is the parent of the second. Since we own and append the `vue-component-mounted` class, that's all we need to wait for, no matter the Vue version we're running.
-
Mark Florian authored
This means running Storybook's regular Vue 2 renderer (using the Vue 2 compiler toolchain), but using a *patched* copy of `@vue/compat` at runtime. These patches come from gitlab-org/gitlab@aa9167c0, and are simply renamed to match the `@gitlab/hybrid-vue` alias here so that `patch-package` can apply them. This only works with full builds, not development builds, as `vue-hot-reload-api`, a dependency of `vue-loader`, reaches into Vue 2 internals that `@vue/compat` doesn't implement (for example, `Vue.config._lifecycleHooks`). This is fine, since this mode is only intended to catch/prevent regressions in compatibility of Vue 3 hybrid mode *before* they reach the GitLab monolith. Note that Storybook needs the runtime template compiler build of Vue, since it relies on `template` properties for its stories. This is why the patches patch `vue.esm-bundler.js` in the same way as `vue.runtime.esm-bundler.js` and `vue.cjs.js` Finally, this adds a script to make it easier to keep the patches in this project in sync with `gitlab-org/gitlab`. Addresses gitlab-org#19700. See also gitlab-org/gitlab!230476.
-
Vanessa Otto authored
Files changed: - components/tabs/tabs.js
-
Thomas Hutterer authored
Implement Vue 3 hybrid mode for Storybook See merge request !5808 Merged-by:
Thomas Hutterer <thutterer@gitlab.com> Approved-by:
Illya Klymov <iklymov@gitlab.com> Approved-by:
Vanessa Otto <votto@gitlab.com> Approved-by:
Thomas Hutterer <thutterer@gitlab.com> Reviewed-by:
Mark Florian <mflorian@gitlab.com>
Reviewed-by: GitLab Duo <gitlab-duo@gitlab.com> Co-authored-by:
Mark Florian <mflorian@gitlab.com> -
🤖 GitLab Bot 🤖 authored
-
Peter Hegman authored
Refactor makeProp() with standard Vue 2 syntax in BV tabs See merge request !5828 Merged-by:
Peter Hegman <phegman@gitlab.com> Approved-by:
Peter Hegman <phegman@gitlab.com> Reviewed-by:
GitLab Duo <gitlab-duo@gitlab.com> Co-authored-by:
Vanessa Otto <votto@gitlab.com>
-
Scott de Jonge authored
Update dependency prettier to v3.8.2 See merge request !5853 Merged-by:
Scott de Jonge <sdejonge@gitlab.com> Approved-by:
Scott de Jonge <sdejonge@gitlab.com> Co-authored-by:
GitLab Renovate Bot <gitlab-bot@gitlab.com>
-
Lorenz van Herwaarden authored
-
Vanessa Otto authored
Replace formOptionsMixin with normalizeOptions utility function See merge request !5836 Merged-by:
Vanessa Otto <votto@gitlab.com> Approved-by:
Vanessa Otto <votto@gitlab.com> Reviewed-by:
GitLab Duo <gitlab-duo@gitlab.com> Co-authored-by:
Lorenz van Herwaarden <lvanherwaarden@gitlab.com> -
🤖 GitLab Bot 🤖 authored