Loading
Commits on Source 16
-
Scott de Jonge authored
-
Scott de Jonge authored
Add value equality check to collections to conditionally update Figma variables when values differ from existing Figma Variable value Add updated count to console logged output
-
Vanessa Otto authored
Fix three issues preventing toasts from rendering correctly in Vue 3 compat (and a pre-existing test ordering bug in Vue 2): 1. $slots is readonly in Vue 3 compat, so bv-toast.js assigning toast.$slots['toast-title'] silently failed. Set slots on the internal instance (toast.$.slots) as functions for Vue 3. 2. renderTitle called $createElement outside a render context, which in Vue 3 compat triggers "resolveComponent can only be used in render() or setup()" and produces broken VNodes. Changed renderTitle to return a deferred render function that is called during the slot evaluation in the component's render cycle. 3. ensureToaster only checked Wormhole.hasTarget() before creating a toaster. If the toaster DOM was removed but the Wormhole registration persisted, no new toaster was created and toasts were portaled to a detached target. Added a DOM existence check to detect and recover from stale toaster state.
-
🤖 GitLab Bot 🤖 authored
-
🤖 GitLab Bot 🤖 authored
-
🤖 GitLab Bot 🤖 authored
-
Vanessa Otto authored
Update dependency style-dictionary to ^5.3.2 See merge request !5667 Merged-by:
Vanessa Otto <votto@gitlab.com> Approved-by:
Vanessa Otto <votto@gitlab.com> Co-authored-by:
GitLab Renovate Bot <gitlab-bot@gitlab.com>
-
Scott de Jonge authored
Update Figma sync script output with updated counts See merge request !5637 Merged-by:
Scott de Jonge <sdejonge@gitlab.com> Approved-by:
Dan MH <dmizzi-harris@gitlab.com> Approved-by:
Mark Florian <mflorian@gitlab.com>
Reviewed-by:
Mark Florian <mflorian@gitlab.com> -
Vanessa Otto authored
Update ESLint and related to ^9.39.3 See merge request !5665 Merged-by:
Vanessa Otto <votto@gitlab.com> Approved-by:
Vanessa Otto <votto@gitlab.com> Co-authored-by:
GitLab Renovate Bot <gitlab-bot@gitlab.com>
-
Mark Florian authored
Update dependency @gitlab/stylelint-config to v6.3.0 See merge request !5663 Merged-by:
Mark Florian <mflorian@gitlab.com>
Approved-by: Paul Gascou-Vaillancourt <pgascouvaillancourt@gitlab.com> Approved-by:
Mark Florian <mflorian@gitlab.com>
Co-authored-by: GitLab Renovate Bot <gitlab-bot@gitlab.com>
-
Mark Florian authored
-
Mark Florian authored
This makes sure `prettier` runs through our `{,S}CSS` files in CI and locally. A few things to note: - It seems that function arguments and a few other things ignore the `trailingComma` setting, and are always stripped out. There's a related [upstream bug](https://github.com/prettier/prettier/issues/6356) about this. - We set `singleQuotes: true` in our `.prettierrc`. I think double quotes are more common/natural in CSS, but in fact setting a workaround for SCSS files for this results in _more_ changes, so I've not changed that. - Some files needed adjustment after `prettier` was done with them to satisy `stylelint`. This is presumably why we [don't run prettier on SCSS files in `gitlab-org/gitlab`](https://gitlab.com/gitlab-org/gitlab/-/blob/f2175ce4282011f132874b205ffae52d012e2b3f/.prettierignore#L11-13). One `stylelint` rule had to be adjusted so that some files could satisfy both tools. -
Mark Florian authored
-
Vanessa Otto authored
Make GlToast work in Vue 3 compat mode See merge request !5639 Merged-by:
Vanessa Otto <votto@gitlab.com> Approved-by:
Illya Klymov <iklymov@gitlab.com> Approved-by:
Mark Florian <mflorian@gitlab.com>
Reviewed-by:
Mark Florian <mflorian@gitlab.com>
Reviewed-by: Vanessa Otto <votto@gitlab.com>
-
Savas Vedova authored
Prettier SCSS See merge request !5651 Merged-by:
Savas Vedova <svedova@gitlab.com>
Approved-by: Scott de Jonge <sdejonge@gitlab.com> Approved-by:
Thomas Hutterer <thutterer@gitlab.com> Approved-by:
Savas Vedova <svedova@gitlab.com>
Reviewed-by:
Mark Florian <mflorian@gitlab.com>
Reviewed-by: Thomas Hutterer <thutterer@gitlab.com> Reviewed-by:
Scott de Jonge <sdejonge@gitlab.com> Co-authored-by:
Mark Florian <mflorian@gitlab.com> -
🤖 GitLab Bot 🤖 authored