Badge component: 12px icon variant
Description
- Currently, badge component only has the option to display 16px icons - this can sometimes look clunky.
- This issue covers the Figma update for the component
- From Single Stat component discussions in Figma:
A 12px icon in the 16px viewbox causes the icons to optically misalign with other elements in nearly every scenario. In this instance doing so would make the icon feel 12px away from the label instead of ~8px and make the left and right badge padding appear to be uneven. -- Jeremy Elder
Figma file
N/A
Checklist
Make sure the following are completed before closing the issue:
- [-] Assignee: Design in your working file. When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team].
- [-] Assignee: Update the link to the working file in the issue description.
- [-] Assignee: Ask a [FE/UX Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma).
- [-] Reviewer: Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
-
Reviewer: Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). -
Maintainer: Review and approve assignee’s changes. -
Maintainer: Add the changes or additions to the target file. For example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file. -
Ensure that all styles and components now belong to the target file. -
For changes to the Component Library file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
-
-
Maintainer: When applicable, [publish][publishing] any library changes along with a clear commit message. - [-] Assignee: Move your working file to the shared Figma project:
-
For Component Library changes, move your file to the [Component archive][component-archive] project. -
For all other changes, move your file to the [Misc archive][misc-archive] project. -
If you’re a community contributor, we ask that you transfer ownership of your draft file to the maintainer so they can move it to our archive, along with its version history and comments.
-
- [-] Assignee (or Maintainer, for community contributions): If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
- [-] Assignee: When applicable, create a merge request in this repository with the [component-guideline template][component-guideline-template] to create or update the component’s documentation page.
- [-] Assignee: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one.
-
Assignee: 🎉 Congrats, you made it! You can now close this issue.