Toggle label and help text
Problem
The proposed style for toggle's label and help text position are not consistent with our Forms guidelines and other components, like Checkboxes or Radio buttons.
Specifically:
- Labels are always bold, except for checkboxes and radio buttons: https://design.gitlab.com/components/forms/#labels
- Checkboxes and radio buttons are part of a fieldset that has its own bold label: https://design.gitlab.com/components/radio-buttons/#labels
- Labels in checkboxes (inline labels) have
8px
spacing between the checkbox and the label - Help text should always be placed below the form element: https://design.gitlab.com/components/forms/#help-text
- The toggle variation with inline label is missing a sub-variation with help text
This states are also missing:
- Focus
- Loading
Solution
Related patterns
Pattern checklist
Make sure these are completed before closing the issue, with a link to the relevant commit, if applicable.
-
Read our contribution guidelines, especially the For GitLabbers section. -
Create a Sketch file in your progress folder just for this pattern and make sure that: -
You have not created a duplicate of an existing pattern, symbol, layer style, or text style. -
You have used the proper method for creating the pattern depending on the complexity. Atoms and molecules are symbols, organisms are groups. -
Typography uses text styles. When applicable, colors use shared styles.
-
-
Ask a UXer to review your Sketch file, linking them to your latest commit so they know where to find it. If they have the capacity, they should assign themselves to this issue. -
QA of your Sketch file by the reviewer. -
Add your changes to the pattern library. When copying things over, watch out for duplicated symbols, layer styles, and text styles. Some of our recommended plugins can help you find and remove duplicates. -
QA of pattern library by the reviewer. -
Create an issue in the Design System to add the pattern documentation. Mark it as related to this issue. -
Add an agenda item to the next UX weekly call to inform everyone (if it's a new pattern, not yet used in the application).
Edited by Pedro Moreira da Silva