Investigate SEO & redirects
From @pgascouvaillancourt in #414 (comment 226448079):
...related to the switch to Auto DevOps: whenever an URL is served by the server, it is redirected to the same URL with a trailing slash.
To reproduce this, access any URL directly, ie: https://design.gitlab.com/brand-basics/basics. You'll be redirected to https://design.gitlab.com/brand-basics/basics/. However, if you navigate away from that page then back to it using the menu, you'll end up on https://design.gitlab.com/brand-basics/basics (without a trailing slash).
This means that server-side rendered pages display incorrect Edit this page links because the client-side router receives the path with a trailing slash, and on the contrary, whenever page is rendered client-side (when navigating with the menu), those links are correct.
Like @syasonik suggested in the issue, we can strip trailing slashes in
editThisPage
options, here's an MR that does it: !1583 (merged)My only concern is that these redirections might hurt SEO because URLs will be referenced with the trailing slash, while all internal links don't have that trailing slash. I'm not sure what the real impact is (if any), it's probably not that bad, but if there's an easy way to prevent the redirects so we have consistent URLs throughout the site, let's do it!
@DylanGriffith since you worked on #353 (closed), could you share your thoughts on this when you get the chance?
In this issue we should determine whether the above change will hurt SEO and if so, what can we do about it?