Create, Build, and Style > Accordions
This issue is to complete the ~"pajamas::create", pajamasbuild, ~"pajamas::style" portion of ~"component::accordions" as part of FY20-Q2 OKR to Improve the quality and consistency of our UI.
This includes a single-source-of-truth component that is implemented in Vue and thoroughly documented on design.gitlab.com. This does not include implementing the component throughout the product.
Related epics:
Related issues:
Checklist
-
Usage documentation is included in Pajamas -
Design specs are included in Pajamas -
Component is built and styled in gitlab-ui according to specs -
Banner on vue tab that warns of incorrect styling is removed from Pajamas -
All demos and todos are complete -
Status is changed to Built
in Pajamas -
Add a reference and link to the completed component in the Engineer Week in Review doc
Checklist for UI/sketch updates
Make sure these are completed before closing the issue, with a link to the relevant commit or issue, if applicable. Get familiar with the Sketch UI Kit documentation which has information on updating files, structure, fonts, and symbols.
-
Author: Create a Sketch file in your progress folder with the changes required for this issue. Try to use existing symbols, layer styles, and text styles. -
Author: Ask another Product Designer to review your personal Sketch file, linking them to your latest commit so they know where to find it. If they have the capacity, they should assign themselves to this issue. If not, try pinging another person. -
Reviewer: Review and approve author's changes in their personal Sketch file, according to the workflow. -
Author: Add your changes to the GitLab Sketch UI Kit (pattern library and/or instance sheet), following this step-by-step process. -
Author: Ask the reviewer to review your changes to the Sketch UI Kit files. -
Reviewer: Review and approve author's changes to the Sketch UI Kit files, according to the workflow. -
Author: Create an issue in the Design System to update the design specs and documentation. Mark it as related to this issue. -
Author: Add a read only (FYI) agenda item to the next UX weekly call to inform everyone of these changes, linking to this issue.
Edited by Kevin Comoli