Skip to content

Comments in GlDrawer has incorrect line-height due to definition in drawer styles

Proposal

We should either: render drawer outside of the main content container or set line-height only for the drawer header.

Problem

Leading aka line-height is supposed to be 21px (1.5 * font-size) but in the drawer it is overridden to be 1rem or 16px.

It causes the line-height/tracking of elements like to take on a smaller line height than elsewhere in GitLab

The assumption of why this line-height is defined because without it, the line-height the drawer content will inherit the line-height of the container block because it’s inserted in-place.

Screenshot/videos

Here is a normal comment overlaid on top of the comment box in the drawer image

line-height-in-drawer