Update Danger to understand reverts
Danger claims the no release is made for reverts, which isn't true:
Otherwise, revert the commit that introduced the bug and push the revert commit (or merge it via a pull request) to the release branch
In both cases semantic-release will publish a new release, so your package users will get the fixed/reverted version.
Danger should be updated to reflect this.
-
@group_9970_bot2 started a discussion: (+2 comments) 2 Warnings ⚠️ This MR will trigger no release ⚠️ You've changed some components or directives, but didn't change corresponding
tests. That's OK as long as you're refactoring existing code. If not, please
consider adding/updating tests.No release
This Merge Request will trigger no release. This means none of the commits warrant a semantic release according to conventional commits rules (e.g. they only update CI config).
To trigger a release, update one or more commit messages.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend in GitLab.org / gitlab-ui Himanshu Kapoor (
@himkp) (UTC+7, 12 hours ahead of@pgascouvaillancourt)Simon Knox (
@psimyn) (UTC+11, 16 hours ahead of@pgascouvaillancourt)Missing spec changes
The following spec files were expected to have changes based on the changes in this Merge Reqest:
src/components/base/form/form_checkbox/form_checkbox_group.spec.jssrc/components/base/form/form_radio_group/form_radio_group.spec.jssrc/components/base/popover/popover.spec.js
Consider adding or updating these to ensure new component/directive behaviors are covered by tests.
If needed, you can retry the
🔁 danger-reviewjob that generated this comment.Generated by
🚫 Danger