Apply suggestion to CONTRIBUTING.md

41 jobs for add-review-label-guidelines in 97 minutes and 24 seconds (queued for 6 seconds)
Status Job ID Name Coverage
  Prebuild
passed #251991279
check feature flags docs

00:01:06

passed #251991272
clone test repo

00:01:57

passed #251991278
dep check

00:01:18

passed #251991271
docker
helper images

00:04:53

manual #251991273
allowed to fail manual
review-docs-deploy
passed #251991275
gitlab-org
tests definitions

00:03:00

 
  Test
passed #251991282
code_quality

00:01:27

passed #251991297
docs lint

00:00:52

passed #251991307
git 1.7.1

00:02:07

passed #251991281
allowed to fail
license_management

00:03:04

passed #251991284
docker
unit test 1/5

00:11:17

passed #251991286
docker
unit test 2/5

00:15:01

passed #251991287
docker
unit test 3/5

00:10:41

passed #251991289
docker
unit test 4/5

00:05:30

passed #251991290
docker
unit test 5/5

00:06:54

passed #251991291
docker allowed to fail
unit test with race 1/5

00:12:25

passed #251991292
docker allowed to fail
unit test with race 2/5

00:18:48

failed #251991293
docker allowed to fail
unit test with race 3/5

00:15:40

passed #251991294
docker allowed to fail
unit test with race 4/5

00:04:03

passed #251991296
docker allowed to fail
unit test with race 5/5

00:07:06

failed #251991298
shell windows-1803 allowed to fail
windows 1803 tests 1/3

00:42:14

failed #251991299
shell windows-1803 allowed to fail
windows 1803 tests 2/3

01:05:46

failed #251991300
shell windows-1803 allowed to fail
windows 1803 tests 3/3

00:18:44

failed #251991304
shell windows-1809 allowed to fail
windows 1809 tests 1/3

00:34:02

failed #251991305
shell windows-1809 allowed to fail
windows 1809 tests 2/3

00:53:09

failed #251991306
shell windows-1809 allowed to fail
windows 1809 tests 3/3

00:14:47

 
  Coverage
passed #251991310
race conditions detector

00:01:01

passed #251991309
test coverage report

00:01:07

63.3%
passed #251991313
test junit report

00:02:10

 
  Build
passed #251991316
gitlab-org
binaries darwin/386 darwin/amd64

00:03:46

passed #251991317
gitlab-org
binaries freebsd/386 freebsd/amd64 freebsd/arm

00:05:11

passed #251991318
gitlab-org
binaries linux/386 linux/amd64 linux/arm

00:04:58

passed #251991319
gitlab-org
binaries windows/386 windows/amd64

00:03:59

 
  Package
passed #251991321
gitlab-org
package-deb

00:02:18

passed #251991325
gitlab-org
package-rpm

00:01:25

 
  Release
passed #251991327
release
development S3

00:01:02

passed #251991328
docker
development docker images

00:03:07

passed #251991329
shell windows-1803
development servercore1803 helper docker image

00:09:59

passed #251991331
shell windows-1809
development servercore1809 helper docker image

00:03:52

passed #251991335
static QA

00:00:35

 
  Cleanup
manual #251991337
allowed to fail manual
review-docs-cleanup
 
Name Stage Failure
failed
windows 1803 tests 2/3 Test
gitlab.com/gitlab-org/gitlab-runner/executors/shell-2

gitlab.com/gitlab-org/gitlab-runner/executors/shell-3
gitlab.com/gitlab-org/gitlab-runner/helpers/archives-0
gitlab.com/gitlab-org/gitlab-runner/helpers/archives-1


Running after script...
$ if (Test-Path $PKG_BUILD_DIR) { $(Get-Item $PKG_BUILD_DIR).Delete() }
ERROR: Job failed: exit status 1
failed
windows 1809 tests 2/3 Test
gitlab.com/gitlab-org/gitlab-runner/executors/shell-2

gitlab.com/gitlab-org/gitlab-runner/executors/shell-3
gitlab.com/gitlab-org/gitlab-runner/helpers/archives-0
gitlab.com/gitlab-org/gitlab-runner/helpers/archives-1


Running after script...
$ if (Test-Path $PKG_BUILD_DIR) { $(Get-Item $PKG_BUILD_DIR).Delete() }
ERROR: Job failed: exit status 1
failed
windows 1803 tests 1/3 Test

WARNING: Failed packages:
WARNING: gitlab.com/gitlab-org/gitlab-runner/common-2
gitlab.com/gitlab-org/gitlab-runner/executors/docker-2


Running after script...
$ if (Test-Path $PKG_BUILD_DIR) { $(Get-Item $PKG_BUILD_DIR).Delete() }
ERROR: Job failed: exit status 1
failed
windows 1809 tests 1/3 Test

WARNING: Failed packages:
WARNING: gitlab.com/gitlab-org/gitlab-runner/common-2
gitlab.com/gitlab-org/gitlab-runner/executors/docker-2


Running after script...
$ if (Test-Path $PKG_BUILD_DIR) { $(Get-Item $PKG_BUILD_DIR).Delete() }
ERROR: Job failed: exit status 1
failed
windows 1803 tests 3/3 Test
ok  	gitlab.com/gitlab-org/gitlab-runner/shells	9.052s

WARNING: Failed packages:
WARNING: gitlab.com/gitlab-org/gitlab-runner/helpers/docker-0


Running after script...
$ if (Test-Path $PKG_BUILD_DIR) { $(Get-Item $PKG_BUILD_DIR).Delete() }
ERROR: Job failed: exit status 1
failed
unit test with race 3/5 Test
coverage: 73.7% of statements
ok gitlab.com/gitlab-org/gitlab-runner/executors/ssh 1.084s
Makefile:134: recipe for target 'parallel_test_execute' failed
make: *** [parallel_test_execute] Error 1
Uploading artifacts...
.cover/*: found 14 matching files
.testoutput/*: found 14 matching files

Uploading artifacts to coordinator... ok
id=251991293 responseStatus=201 Created token=H1buPt74
ERROR: Job failed: exit code 1
failed
windows 1809 tests 3/3 Test
ok  	gitlab.com/gitlab-org/gitlab-runner/shells	13.717s

WARNING: Failed packages:
WARNING: gitlab.com/gitlab-org/gitlab-runner/helpers/docker-0


Running after script...
$ if (Test-Path $PKG_BUILD_DIR) { $(Get-Item $PKG_BUILD_DIR).Delete() }
ERROR: Job failed: exit status 1