Fix data race in helpers.MakeFatalToPanic()

30 jobs for logrus in 27 minutes and 37 seconds (queued for 1 second)
Status Job ID Name Coverage
  Prebuild
passed #95177195
clone test repo

00:00:37

passed #95177194
docker
helper images

00:04:41

manual #95177196
allowed to fail manual
review-docs-deploy
passed #95177197
gitlab-org
tests definitions

00:02:32

 
  Test
passed #95177198
code_quality

00:04:12

passed #95177210
docs check links

00:00:24

passed #95177212
git 1.7.1

00:01:36

failed #95177211
integration windows allowed to fail
integration windows

00:00:01

passed #95177199
docker
unit tests 0 5

00:05:37

passed #95177200
docker
unit tests 1 5

00:08:13

passed #95177202
docker
unit tests 2 5

00:06:19

passed #95177203
docker
unit tests 3 5

00:02:29

passed #95177204
docker
unit tests 4 5

00:03:22

failed #95177205
docker allowed to fail
unit tests with race 0 5

00:04:56

failed #95177206
docker allowed to fail
unit tests with race 1 5

00:09:17

failed #95177207
docker allowed to fail
unit tests with race 2 5

00:06:44

passed #95177208
docker allowed to fail
unit tests with race 3 5

00:02:47

failed #95177209
docker allowed to fail
unit tests with race 4 5

00:04:00

 
  Coverage
passed #95177214
race conditions detector

00:01:50

passed #95177213
test coverage report

00:01:08

52.4%
 
  Build
passed #95177216
gitlab-org
binaries darwin/386 darwin/amd64

00:03:41

passed #95177217
gitlab-org
binaries freebsd/386 freebsd/amd64 freebsd/arm

00:05:20

passed #95177218
gitlab-org
binaries linux/386 linux/amd64 linux/arm

00:04:45

passed #95177219
gitlab-org
binaries windows/386 windows/amd64

00:04:00

 
  Package
passed #95177221
gitlab-org
package-deb

00:01:58

passed #95177222
gitlab-org
package-rpm

00:01:53

 
  Release
passed #95177223
release
development S3

00:01:08

passed #95177224
docker
development docker images

00:04:19

passed #95177225
static QA

00:00:22

 
  Cleanup
manual #95177226
allowed to fail manual
review-docs-cleanup
 
Name Stage Failure
failed
unit tests with race 1 5 Test
exit status 1
FAIL gitlab.com/gitlab-org/gitlab-runner/executors/docker/machine 0.098s
Makefile:133: recipe for target 'parallel_test_execute' failed
make: *** [parallel_test_execute] Error 1
Uploading artifacts...
.cover/*: found 10 matching files
.testoutput/*: found 10 matching files

Uploading artifacts to coordinator... ok
id=95177206 responseStatus=201 Created token=KsFvtNXV
ERROR: Job failed: exit code 1
failed
unit tests with race 4 5 Test
coverage: 14.4% of statements
ok gitlab.com/gitlab-org/gitlab-runner/shells 1.052s
Makefile:133: recipe for target 'parallel_test_execute' failed
make: *** [parallel_test_execute] Error 1
Uploading artifacts...
.cover/*: found 9 matching files
.testoutput/*: found 9 matching files

Uploading artifacts to coordinator... ok
id=95177209 responseStatus=201 Created token=dJnQt7xs
ERROR: Job failed: exit code 1
failed
integration windows Test
+   Remove-Item -Force -Recurse "c:\gitlab-runner\builds\7816523a\0\gitlab-org\git ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : WriteError: (C:\gitlab-runne...g\gitlab-runner:String) [Remove-Item], DirectoryNotFoundE
xception
+ FullyQualifiedErrorId : RemoveItemIOError,Microsoft.PowerShell.Commands.RemoveItemCommand

Cloning repository...
fatal: destination path 'c:/gitlab-runner/builds/7816523a/0/gitlab-org/gitlab-runner' already exists and is not an empty directory.
ERROR: Job failed: exit status 1
failed
unit tests with race 0 5 Test
coverage: 33.8% of statements
ok gitlab.com/gitlab-org/gitlab-runner/common 1.138s
Makefile:133: recipe for target 'parallel_test_execute' failed
make: *** [parallel_test_execute] Error 1
Uploading artifacts...
.cover/*: found 10 matching files
.testoutput/*: found 10 matching files

Uploading artifacts to coordinator... ok
id=95177205 responseStatus=201 Created token=NN54SE_1
ERROR: Job failed: exit code 1
failed
unit tests with race 2 5 Test
coverage: 3.7% of statements
ok gitlab.com/gitlab-org/gitlab-runner/executors/virtualbox 1.039s
Makefile:133: recipe for target 'parallel_test_execute' failed
make: *** [parallel_test_execute] Error 1
Uploading artifacts...
.cover/*: found 10 matching files
.testoutput/*: found 10 matching files

Uploading artifacts to coordinator... ok
id=95177207 responseStatus=201 Created token=8hAbnfgY
ERROR: Job failed: exit code 1