Merge branch 'patch-61' into 'master'

Improve wording in docs/development/README.md

See merge request !1837
55 jobs for !1837 with patch-61 into master in 49 minutes and 38 seconds (queued for 3 seconds)
Status Job ID Name Coverage
  Prebuild
passed #441807528
clone test repo

00:01:27

passed #441807527
docker
helper images

00:09:26

passed #441807530
gitlab-org
tests definitions

00:04:43

 
  Test
passed #441807534
check feature flags docs

00:01:40

passed #441807537
check mocks

00:03:34

passed #441807536
check modules

00:01:44

passed #441807539
code_quality

00:02:03

passed #441807533
docs lint

00:00:53

passed #441807589
git 1.7.1

00:02:40

passed #441807532
license_management

00:09:42

passed #441807541
docker
unit test 1/8

00:03:13

passed #441807543
docker
unit test 2/8

00:04:04

passed #441807544
docker
unit test 3/8

00:12:21

passed #441807545
docker
unit test 4/8

00:03:39

passed #441807546
docker
unit test 5/8

00:03:59

passed #441807548
docker
unit test 6/8

00:02:40

passed #441807551
docker
unit test 7/8

00:03:50

passed #441807553
docker
unit test 8/8

00:02:39

passed #441807557
docker
unit test with race 1/8

00:05:23

passed #441807558
docker
unit test with race 2/8

00:04:43

passed #441807559
docker
unit test with race 3/8

00:14:42

failed #441807563
docker allowed to fail
unit test with race 4/8

00:06:10

passed #441807564
docker
unit test with race 5/8

00:04:34

passed #441807566
docker
unit test with race 6/8

00:04:07

passed #441807567
docker
unit test with race 7/8

00:04:41

passed #441807568
docker
unit test with race 8/8

00:04:02

failed #441807570
shell windows-1803 allowed to fail
windows 1803 tests 1/3

00:05:53

failed #441807571
shell windows-1803 allowed to fail
windows 1803 tests 2/3

00:18:52

failed #441807572
shell windows-1803 allowed to fail
windows 1803 tests 3/3

00:03:05

passed #441807573
windows-1809 windows shared-windows
windows 1809 tests 1/8

00:09:49

failed #441807577
windows-1809 windows shared-windows allowed to fail
windows 1809 tests 2/8

00:20:18

failed #441807580
windows-1809 windows shared-windows allowed to fail
windows 1809 tests 3/8

00:09:06

failed #441807584
windows-1809 windows shared-windows allowed to fail
windows 1809 tests 4/8

00:19:10

failed #441807585
windows-1809 windows shared-windows allowed to fail
windows 1809 tests 5/8

00:23:54

failed #441807586
windows-1809 windows shared-windows allowed to fail
windows 1809 tests 6/8

00:07:04

passed #441807587
windows-1809 windows shared-windows
windows 1809 tests 7/8

00:07:57

passed #441807588
windows-1809 windows shared-windows
windows 1809 tests 8/8

00:08:24

 
  Coverage
passed #441807594
check windows 1803 test failures

00:01:27

passed #441807596
check windows 1809 test failures

00:01:23

passed #441807592
race conditions detector

00:01:38

passed #441807590
test coverage report

00:01:37

64.6%
passed #441807591
test junit report

00:01:39

 
  Build
passed #441807600
gitlab-org
binaries darwin/386 darwin/amd64

00:04:06

passed #441807602
gitlab-org
binaries freebsd/386 freebsd/amd64 freebsd/arm

00:05:20

passed #441807604
gitlab-org
binaries linux/386 linux/amd64 linux/arm linux/arm64

00:05:56

passed #441807606
gitlab-org
binaries windows/386 windows/amd64

00:04:31

 
  Package
passed #441807608
gitlab-org
package-deb

00:03:37

passed #441807611
gitlab-org
package-rpm

00:02:27

 
  Release
passed #441807612
release
development S3

00:01:16

passed #441807613
release
development docker images

00:01:48

passed #441807614
shell windows-1803
development servercore1803 helper docker image

00:03:08

passed #441807616
windows-1809 windows shared-windows
development servercore1809 helper docker image

00:10:15

passed #441807619
static QA

00:00:29

 
  Docs
manual #441807626
allowed to fail manual
review-docs-cleanup
manual #441807623
allowed to fail manual
review-docs-deploy
 
Name Stage Failure
failed
windows 1809 tests 5/8 Test
GO version:   go1.8.7
Built: 2019-08-22T13:06:07+0000
OS/Arch: windows/amd64
Uploading artifacts...
Runtime platform
arch=amd64 os=windows pid=4756 revision=a987417a version=12.2.0
.testoutput/*: found 10 matching files

WARNING: Failed to load system CertPool: crypto/x509: system root pool is not available on Windows
Uploading artifacts to coordinator... ok
id=441807585 responseStatus=201 Created token=oR44mmqn
ERROR: Job failed: exit status 1
failed
windows 1803 tests 2/3 Test
GO version:   go1.13.4
Built: 2019-12-22T11:55:34+0000
OS/Arch: windows/amd64
Uploading artifacts...
Runtime platform
arch=amd64 os=windows pid=35180 revision=ac8e767a version=12.6.0
.testoutput/*: found 25 matching files

WARNING: Failed to load system CertPool: crypto/x509: system root pool is not available on Windows
Uploading artifacts to coordinator... ok
id=441807571 responseStatus=201 Created token=CMKpBVfu
ERROR: Job failed: exit status 1
failed
windows 1809 tests 2/8 Test
GO version:   go1.8.7
Built: 2019-08-22T13:06:07+0000
OS/Arch: windows/amd64
Uploading artifacts...
Runtime platform
arch=amd64 os=windows pid=1928 revision=a987417a version=12.2.0
.testoutput/*: found 10 matching files

WARNING: Failed to load system CertPool: crypto/x509: system root pool is not available on Windows
Uploading artifacts to coordinator... ok
id=441807577 responseStatus=201 Created token=wWs7ke_3
ERROR: Job failed: exit status 1
failed
windows 1809 tests 4/8 Test
GO version:   go1.8.7
Built: 2019-08-22T13:06:07+0000
OS/Arch: windows/amd64
Uploading artifacts...
Runtime platform
arch=amd64 os=windows pid=3520 revision=a987417a version=12.2.0
.testoutput/*: found 10 matching files

WARNING: Failed to load system CertPool: crypto/x509: system root pool is not available on Windows
Uploading artifacts to coordinator... ok
id=441807584 responseStatus=201 Created token=QunhgnDq
ERROR: Job failed: exit status 1
failed
windows 1803 tests 3/3 Test
GO version:   go1.13.4
Built: 2019-12-22T11:55:34+0000
OS/Arch: windows/amd64
Uploading artifacts...
Runtime platform
arch=amd64 os=windows pid=37176 revision=ac8e767a version=12.6.0
.testoutput/*: found 25 matching files

WARNING: Failed to load system CertPool: crypto/x509: system root pool is not available on Windows
Uploading artifacts to coordinator... ok
id=441807572 responseStatus=201 Created token=A3Z3BXuU
ERROR: Job failed: exit status 1
failed
windows 1809 tests 3/8 Test
GO version:   go1.8.7
Built: 2019-08-22T13:06:07+0000
OS/Arch: windows/amd64
Uploading artifacts...
Runtime platform
arch=amd64 os=windows pid=4528 revision=a987417a version=12.2.0
.testoutput/*: found 10 matching files

WARNING: Failed to load system CertPool: crypto/x509: system root pool is not available on Windows
Uploading artifacts to coordinator... ok
id=441807580 responseStatus=201 Created token=dCxtBxfx
ERROR: Job failed: exit status 1
failed
windows 1803 tests 1/3 Test
GO version:   go1.13.4
Built: 2019-12-22T11:55:34+0000
OS/Arch: windows/amd64
Uploading artifacts...
Runtime platform
arch=amd64 os=windows pid=35232 revision=ac8e767a version=12.6.0
.testoutput/*: found 25 matching files

WARNING: Failed to load system CertPool: crypto/x509: system root pool is not available on Windows
Uploading artifacts to coordinator... ok
id=441807570 responseStatus=201 Created token=G7yT69KW
ERROR: Job failed: exit status 1
failed
windows 1809 tests 6/8 Test
GO version:   go1.8.7
Built: 2019-08-22T13:06:07+0000
OS/Arch: windows/amd64
Uploading artifacts...
Runtime platform
arch=amd64 os=windows pid=4992 revision=a987417a version=12.2.0
.testoutput/*: found 10 matching files

WARNING: Failed to load system CertPool: crypto/x509: system root pool is not available on Windows
Uploading artifacts to coordinator... ok
id=441807586 responseStatus=201 Created token=nXHbz6nY
ERROR: Job failed: exit status 1
failed
unit test with race 4/8 Test
PASS
coverage: 54.5% of statements
ok gitlab.com/gitlab-org/gitlab-runner/executors/shell 9.957s coverage: 54.5% of statements
make: *** [Makefile:116: parallel_test_execute] Error 1
Uploading artifacts...
.cover/*: found 10 matching files
.testoutput/*: found 10 matching files

Uploading artifacts to coordinator... ok
id=441807563 responseStatus=201 Created token=PKrYXnER
ERROR: Job failed: exit code 1