Skip to content

Add /etc/nsswitch.conf to helper on docker executor to read /etc/hosts when upload artifacts

Jun Sekine requested to merge jsoizo/gitlab-runner:1845_fix_artifacts_upload_failure_on_docker into master

What does this MR do?

Add /etc/nsswitch.conf when building image of runner_helper image.

Why was this MR needed?

In case of GitLab on closed network, it is necessary adding extra hosts to gitlab-runner's container setting config.toml. However after test & build, when upload artifacts to GitLab by runner-helper container, it contains the extra hosts at /etc/hosts file but it is not read by uploader.

To Solve this problem, I added config to nsswitch.conf that read /etc/hosts primarily when resolve hosts.

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

#1845 (closed)

Edited by Jun Sekine

Merge request reports