Update docker minimum API Version to docker for windows minimum supported version.
What does this MR do?
Raising the minimum API Version of docker from 1.18 to 1.24.
Why was this MR needed?
Docker-EE on Windows Server 2016 (LTSB) does not support API Version 1.18. The minimum supported Version is 1.24. If one tries to access /v1.18/info dockerd only returns returncode 404 with the body set to this message:
client version 1.18 is too old. Minimum supported API version is 1.24, please upgrade your client to a newer version
Are there points in the code the reviewer needs to double check?
Compatibility with older docker API versions. If the minimum version could not be raised in general, some logic has to be implemented to only set it to 1.24 for windows builds, or more specifically if dealing with a windows docker deamon.
Outstanding: Gitlab-runner pulls the wrong (as there is currently no other) version of gitlab-runner-helper docker image. The one it pulls if for linux and that one cannot run on a windows only docker host. So it is still not fully working on Windows Server 2016 LTSB, but should work on Windows Server 1709 and up.
Does this MR meet the acceptance criteria?
-
Documentation created/updated - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Branch has no merge conflicts with master(if you do - rebase it please)