Skip to content
Snippets Groups Projects

Populate a list of machines with machines that might not yet be persisted on disk

All threads resolved!

What does this MR do?

This tries to solve the issue described in: #2342 (comment 69862409).

This also solves issues with #3424 (closed) since this merge request prevents from creating too many instances so we don't consume the AWS API that much and prevent from being rate limited.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Closes #2342 (closed) Related to #3424 (closed)

Edited by Steve Xuereb

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 🤖 GitLab Bot 🤖 changed milestone to %12.1

    changed milestone to %12.1

  • 🤖 GitLab Bot 🤖 changed milestone to %12.2

    changed milestone to %12.2

  • removed ReviewP1 label

  • Tomasz Maczukin changed the description

    changed the description

  • added [Deprecated] Category:Runner devopsverify grouprunner labels and removed 1 deleted label

  • @ayufan It looks OK. But can we add some tests for this?

  • Tomasz Maczukin assigned to @ayufan and unassigned @tmaczukin

    assigned to @ayufan and unassigned @tmaczukin

  • Author Maintainer

    @tmaczukin Could you take over this? :)

  • 🤖 GitLab Bot 🤖 changed milestone to %12.3

    changed milestone to %12.3

  • mentioned in issue #4729 (closed)

  • mentioned in issue #4734 (closed)

  • 🤖 GitLab Bot 🤖 changed milestone to %12.4

    changed milestone to %12.4

  • reopened

  • Steve Xuereb changed the description

    changed the description

  • Since this is related to #3424 (closed) which I'm working on currently I'm going to take over this MR to add some tests and get it ready for merging.

  • Steve Xuereb assigned to @steveazz and unassigned @tmaczukin

    assigned to @steveazz and unassigned @tmaczukin

  • mentioned in issue #4798 (closed)

  • Steve Xuereb added 1616 commits

    added 1616 commits

    Compare with previous version

  • Steve Xuereb resolved all threads

    resolved all threads

  • Steve Xuereb added 1 commit

    added 1 commit

    • 626243b6 - Fix race docker-machine race condition on creation

    Compare with previous version

  • Steve Xuereb changed milestone to %12.5

    changed milestone to %12.5

  • @tmaczukin do you think you can review this? It's a fix for #3424 (closed) as well :bow:

  • Steve Xuereb assigned to @tmaczukin and unassigned @steveazz

    assigned to @tmaczukin and unassigned @steveazz

  • Steve Xuereb changed the description

    changed the description

  • Steve Xuereb added 1 commit

    added 1 commit

    • f0697918 - Fix race docker-machine race condition on creation

    Compare with previous version

  • Tomasz Maczukin approved this merge request

    approved this merge request

  • @steveazz LGTM. I've left my approval - feel free to merge it :)

  • Steve Xuereb mentioned in commit b49e4fd1

    mentioned in commit b49e4fd1

  • merged

  • Please register or sign in to reply
    Loading