Populate a list of machines with machines that might not yet be persisted on disk
What does this MR do?
This tries to solve the issue described in: #2342 (comment 69862409).
This also solves issues with #3424 (closed) since this merge request prevents from creating too many instances so we don't consume the AWS API that much and prevent from being rate limited.
Does this MR meet the acceptance criteria?
-
Documentation created/updated - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Branch has no merge conflicts with master
(if you do - rebase it please)
What are the relevant issue numbers?
Closes #2342 (closed) Related to #3424 (closed)
Merge request reports
Activity
mentioned in issue #2342 (closed)
added ~2278654 typebug executordocker-machine labels
added 1 commit
- 7b3d3dc8 - Populate a list of machines with machines that might not yet be persisted on disk
added customer label
changed milestone to %11.0
User confirmed the fix, let's try to make this real for %11.0
mentioned in issue #3424 (closed)
changed milestone to %11.5
added ReviewP1 label
assigned to @tmaczukin
- Resolved by Steve Xuereb
changed milestone to %12.1
added missed:11.5 label
changed milestone to %12.2
added missed:12.1 label
removed ReviewP1 label
added [Deprecated] Category:Runner devopsverify grouprunner labels and removed 1 deleted label
@ayufan It looks OK. But can we add some tests for this?
assigned to @ayufan and unassigned @tmaczukin
@tmaczukin Could you take over this? :)
assigned to @tmaczukin
unassigned @ayufan
changed milestone to %12.3
added missed:12.2 label
mentioned in issue #4729 (closed)
added missed:12.3 label
mentioned in issue #4734 (closed)
changed milestone to %12.4
Since this is related to #3424 (closed) which I'm working on currently I'm going to take over this MR to add some tests and get it ready for merging.
assigned to @steveazz and unassigned @tmaczukin
mentioned in issue #4798 (closed)
added missed:12.4 label
added 1616 commits
-
7b3d3dc8...85a7a037 - 1615 commits from branch
master
- 41b432e5 - Fix race docker-machine race condition on creation
-
7b3d3dc8...85a7a037 - 1615 commits from branch
added 1 commit
- 626243b6 - Fix race docker-machine race condition on creation
added Deliverable label
changed milestone to %12.5
@tmaczukin do you think you can review this? It's a fix for #3424 (closed) as well
assigned to @tmaczukin and unassigned @steveazz
added 1 commit
- f0697918 - Fix race docker-machine race condition on creation
mentioned in commit b49e4fd1