Skip to content

Handle untracked files with Unicode characters in filenames.

Alexander Kutelev requested to merge kutelev/gitlab-runner:untracked-files into master

What does this MR do?

Made changes make possible detection of untracked files with non-ASCII characters in filenames.

Why was this MR needed?

Without suggested changed GitLab Runner is not capable of finding all untracked files when untracked: true option is used.

On Windows GitLab Runner complains if there are untracked files with non-ASCII characters in filenames:

WARNING: "Merhaba d\303\274nya!": GetFileAttributesEx "Merhaba d/303/274nya!": The filename, directory name, or volume label syntax is incorrect.
WARNING: "\320\237\321\200\320\270\320\262\320\265\321\202, \320\274\320\270\321\200!": GetFileAttributesEx "/320/237/321/200/320/270/320/262/320/265/321/202, /320/274/320/270/321/200!": The filename, directory name, or volume label syntax is incorrect.
WARNING: "\343\203\217\343\203\255\343\203\274\343\203\273\343\203\257\343\203\274\343\203\253\343\203\211": GetFileAttributesEx "/343/203/217/343/203/255/343/203/274/343/203/273/343/203/257/343/203/274/343/203/253/343/203/211": The filename, directory name, or volume label syntax is incorrect.
untracked: found 1 files

In any case not all untracked files are found and as result they are missing from artifacts.

In a testing environment only 1 of 4 files is found:

  • Hello, world! <- Found
  • Привет, мир! <- Not found
  • Merhaba dünya! <- Not found
  • ハロー・ワールド <- Not found

Are there points in the code the reviewer needs to double check?

Amount of changes is very small, it worth reviewing everything.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Fixes #3462 (closed)

Edited by Alexander Kutelev

Merge request reports