Skip to content

Cache the connectivity of live Docker Machine instances

Joel Low requested to merge lowjoel/gitlab-runner:cache-docker-machine-can-connect into master

What does this MR do?

This adds a connectivity cache for instances managed by Docker Machine, to work around API limits imposed by cloud providers.

Why was this MR needed?

This fixes #3296 (closed).

Are there points in the code the reviewer needs to double check?

I have only tested this on AWS, and I'm not sure if the behaviour makes sense for other cloud providers. In the case of AWS, this reduced the number of DescribeInstances API calls by almost 80%.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

closes #3296 (closed)

Edited by Alessio Caiazza

Merge request reports