Skip to content

Add fix for race condition in windows cache extraction

Sean Escriva requested to merge webframp/gitlab-runner:fix/windows-cache-extractor into master

What does this MR do?

This removes the defer on closing the file used in the download moves the close to later in the function.

Why was this MR needed?

This MR is a naive attempt at addressing the cache extraction failures that were happen on windows when the cache file size is larger than roughly 213,000 KB in size: #2574 (closed)

Are there points in the code the reviewer needs to double check?

Removing the defer may not actually be the safest way to handle this, but in testing has provided a resolution for our problem.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Closes #2574 (closed)

Edited by Steve Xuereb

Merge request reports