WIP: Label CI build pods on Kubernetes for web terminal access
What does this MR do?
Labels Kubernetes build pods with gitlab.com/build=<build_id>. This label meets constraints and guidelines detailed in the Kubernetes docs: https://k8s.io/docs/concepts/overview/working-with-objects/labels/ - we can change to anything as long as:
- The prefix (part before
/) is a DNS name <= 253 chars - The name (part after
/) is alphanumeric <= 63 chars - The value is alphanumeric <= 63 chars
What changes are missing in this?
-
Holding on to the pod for some time after the build completes
Why was this MR needed?
Required for https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/17281. So that Gitlab can map a given build to the correct pod when attempting to open a web terminal.
Are there points in the code the reviewer needs to double check?
Does this MR meet the acceptance criteria?
-
Documentation created/updated - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Branch has no merge conflicts with master(if you do - rebase it please)
What are the relevant issue numbers?
Edited by Vicky Chijwani