Skip to content

Added docker runtime support

Ahmad Kiswani requested to merge ahmadki/gitlab-runner:docker-runtime into master

What does this MR do?

Adds support for docker's runtime flag.

Why was this MR needed?

Access to the flag is necessary in some scenarios, for example accessing GPUs through nvidia-docker:

Previous solution with --docker-volume-driver, --docker-volumes and --docker-devices is not ideal as it binds to a specific driver version. These flags can now be replaced with --docker-runtime nvidia (provided nvidia-docker2 is installed).

Are there points in the code the reviewer needs to double check?

The modification is straight forward (a single addition to HostConfig).

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

#2465 (closed)

Edited by Ahmad Kiswani

Merge request reports