Fix race in helpers/prometheus/log_hook.go: Fire() method
All threads resolved!
All threads resolved!
What does this MR do?
Fixes races that can occur with concurrent calls to Fire() in helpers/prometheus/log_hook.go
.
Why was this MR needed?
https://gitlab.com/gitlab-com/infrastructure/issues/1079#note_22260206
Are there points in the code the reviewer needs to double check?
Does this MR meet the acceptance criteria?
-
Documentation created/updated - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Branch has no merge conflicts with master
(if you do - rebase it please)
What are the relevant issue numbers?
Merge request reports
Activity
- Resolved by Tomasz Maczukin
assigned to @tmaczukin
assigned to @ayufan
- Resolved by Tomasz Maczukin
- Resolved by Tomasz Maczukin
assigned to @tmaczukin
@ayufan Updated!
assigned to @ayufan
enabled an automatic merge when the pipeline for e27af8a7 succeeds
mentioned in commit b4c159dc
mentioned in commit 8e829463
Please register or sign in to reply