Skip to content

WIP: Re-use process termination mechanism from Custom executor in Shell executor

Tomasz Maczukin requested to merge new-process-killing into master

👋

This merge request has been broken into multiple ones:

  1. Extract process killer form custom executor
  2. Extract commander interface from custom executor
  3. Add Process groups to process pkg
  4. Send SIGTERM then SIGKILL for shell executor

With all the feedback implemented. Closing this merge request since it's surpassed. Thank all for the help!

What does this MR do?

Extracts the process killing mechanism from Custom executor and adds it as a new default mechanism for Shell executor. The old mechanism is still available, but it's covered with a feature flag.

Why was this MR needed?

To resolve issues like #3101 (closed) and #3031 (closed).

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

closes #4438 (closed)

Edited by Steve Xuereb

Merge request reports