Skip to content

Cleanup feature flags mess

Tomasz Maczukin requested to merge cleanup-feature-flags-mess into master

What does this MR do?

Cleans up a little mess that we have with feature flags definition and adds automation for documentation table generation.

Why was this MR needed?

1. We currently have a mess with how FFs are defined and used:

  • one of the FFs had no explicit default value definition (while the others have),
  • two FFs were defined as constants and used as constants, while two others were used as direct strings in the code.

This MR makes all the definitions consistent and prepares a single source of truth for the information about available FFs.

2. The documentation of the specific FFs is managed manually. It makes things easy to forget. The inspiration for preparing this part of the change was !1297 (closed) that I'm working on. It adds a new FF and I totally forgot that we have a documentation page for them. There is of course the changes that it would be noticed by the reviewer, but if we can automatize this, then why not!? :)

Limited to only cleaning up the current mess. The single source of truth and docs generation mechanism will get its own MR :) (=> !1313 (merged))

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

Edited by Steve Xuereb

Merge request reports