Skip to content

Log time took preparing executors

Matthew requested to merge gaff/gitlab-runner:log-executor-times into master

What does this MR do?

This change means the runner records timing information when Preparing executors.

Closes #3987 (closed)

Why was this MR needed?

This includes time taken to procure hosts, and pull docker images - so can be a significant part of any build.

Are there points in the code the reviewer needs to double check?

I've never written any go before. Nor am I really sure how to test this - sorry.

In particular the BuildSection helper takes a function that returns an error only. This means some of the function deferring is rather ugly. No idea what the idomatic way to fix this in go is.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

See: #3982 (closed)

Edited by Alessio Caiazza

Merge request reports