Split `make docker` for GitLab Runner Helper
What does this MR do?
make docker for GitLab Runner Helper to build binaries and containers separately
Why was this MR needed?
Take 2 of !1174 (merged) but this time it doesn't rename the final tarball so the runner will pick it up.
GitLab Runner helper is built using
make docker which builds the
binary, creates a Docker container and extract the files system of that
container for publishing at a later stage.
Because of #3755 (closed) we have to split this command up so we generate the binaries and the docker archive separately since Windows containers cannot be built on Linux systems or vice versa.
We are keeping the binary generation in one command to have both Windows and Linux binaries consistent, and the diverging on how we create the containers since they need to done separately.
The create of the container for Linux based image will stay in the Makefile since it's perfectly fine. For windows it will be separate powershell script since to run natively on Windows since we cannot run bash on windows server.
The reason for this, so that we keep the binary generation consistent between both platforms and then
Drop support for
USE_PRECOMPILED_IMAGES since it's just extra
complexity that is not needed.
Are there points in the code the reviewer needs to double check?
- File can still be loaded locally
Does this MR meet the acceptance criteria?
- Documentation created/updated
- Added tests for this feature/bug
In case of conflicts with
master- branch was rebased