Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
gitlab-runner
gitlab-runner
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 1,319
    • Issues 1,319
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 184
    • Merge Requests 184
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • Container Registry
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • gitlab-runnergitlab-runner
  • Issues
  • #4073

You need to sign in or sign up before continuing.
Closed
Open
Opened Mar 20, 2019 by Steve Azzopardi@steveazz
  • Report abuse
  • New issue
Report abuse New issue

Remove FF_K8S_USE_ENTRYPOINT_OVER_COMMAND feature flag

Description

In 11.4 GitLab Runner introduced a feature flag FF_K8S_USE_ENTRYPOINT_OVER_COMMAND in order to fix issues like #2338 (closed) & #3536 (closed)

The value of image:command: from .gitlab-ci.yml, if defined, was overwriting image's entrypoint. While it was defined as the command understood in docker run way. For K8S args should be used. And there was also inconsistency because if only command was used, then it was overwriting the entrypoint, but if also entrypoint was used then it was being assigned into the right place.

With 12.0 we're fixing the implementation. command, if defined in the yaml file, will be always passed as K8S' args. entrypoint, if defined in the yaml file, will be always passed as K8S' command.

Proposal

Remove FF_K8S_USE_ENTRYPOINT_OVER_COMMAND and start using the command over the entry point when it's defined (basically, the behavior when the feature flag is turned off)

Links to related issues and merge requests / references

Main depreciation issue #3473 (closed) MR introducing feature flag !1010 (merged)

Edited Mar 20, 2019 by Steve Azzopardi

Related issues

  • Discussion
  • Designs
Assignee
Assign to
12.0
Milestone
12.0
Assign milestone
Time tracking
None
Due date
None
5
Labels
Category:Runner Deliverable Verify [DEPRECATED] deprecation devops::verify
Assign labels
  • View project labels
Reference: gitlab-org/gitlab-runner#4073