Add support for window for volume mounting
Description
When building volumes for the docker executor, we are validating and building unix parts in the following parts:
-
Adding Volumes - This will not work right now for windows since we are splitting via
: -
Checking if host mounted volume - This will not work right now for windows since we are splitting via
: - Create Build Volume - We are checking if it's root for Linux but not checking for Windows Path
-
addHostVolume - We merge the two paths with
:which causes confusion later since we split via:
When creating the build volume and user volumes we assume unix pathvolumes we assume unix path, to support windows we have to check the runtime of the runner of configured Docker Engine and handle this accordingly.
Proposal
This was already done in !706 (diffs) with a concrete example, which uses splitWindowsPath that was copied from docker source code itslef, but since we are importing github.com/docker/docker we can use it directly .
Links to related issues and merge requests / references
Edited by Steve Xuereb