gitlab-runner issueshttps://gitlab.com/gitlab-org/gitlab-runner/-/issues2022-08-01T20:28:42Zhttps://gitlab.com/gitlab-org/gitlab-runner/-/issues/4351Follow-up from "Restore gofmt rules from before codeclimate update"2022-08-01T20:28:42ZTomasz Maczukintomasz@gitlab.comFollow-up from "Restore gofmt rules from before codeclimate update"The following discussion from !1408 should be addressed:
- [ ] @steveazz started a [discussion](https://gitlab.com/gitlab-org/gitlab-runner/merge_requests/1408#note_179908325): (+2 comments)
> @tmaczukin should we add a comment ex...The following discussion from !1408 should be addressed:
- [ ] @steveazz started a [discussion](https://gitlab.com/gitlab-org/gitlab-runner/merge_requests/1408#note_179908325): (+2 comments)
> @tmaczukin should we add a comment explaining why we have to prepare the gofmt analyzer and why we are using the specific version? Or do you think git blame is enough?
>
> Also, can we create a follow-up issue to remove this with the label of ~"upgrade GO from 1.8" so that we can keep track of removing this version pinning?
---
So the thing is that when we'll update from Go 1.8.7, we should be able to start using Go 1.12. And then we should remove the custom image specification for the `gofmt` analyzer in `scripts/codequlity` script.Backloghttps://gitlab.com/gitlab-org/gitlab-runner/-/issues/4016Does not compile with go 1.12 (mknod.go:12:22: cannot use dev (type int) as t...2022-08-01T20:29:32ZMatthias FechnerDoes not compile with go 1.12 (mknod.go:12:22: cannot use dev (type int) as type uint64 in argument to syscall.Mknod)## Summary
While trying to compile with go 1.12 following error message is displayed:
===> Building for gitlab-runner-11.7.0
executors/docker/bindata.go
# github.com/docker/docker/pkg/system
src/github.com/docker/docker/pkg/system/mkno...## Summary
While trying to compile with go 1.12 following error message is displayed:
===> Building for gitlab-runner-11.7.0
executors/docker/bindata.go
# github.com/docker/docker/pkg/system
src/github.com/docker/docker/pkg/system/mknod.go:12:22: cannot use dev (type int) as type uint64 in argument to syscall.Mknod
*** Error code 2
Stop.
make: stopped in /usr/ports/devel/gitlab-runner
### Solution
Wait for https://github.com/moby/moby/pull/38818 to get merged and sorted out, update the dependency.