1. 03 Apr, 2019 3 commits
  2. 01 Apr, 2019 1 commit
  3. 21 Mar, 2019 1 commit
    • Tomasz Maczukin's avatar
      Remove unnecessary log alias for logrus inport · d9e9d81c
      Tomasz Maczukin authored
      Some time ago [we had a discussion](!934 (comment 91891281))
      about why we're aliasing some of the imports of `github.com/sirupsen/logrus`
      package with a `log` alias.
      
      At that moment we've been doing that in 17 from 68 cases when logrus
      was imported in Runners codebase.
      
      The conclusion was this aliasing is unnecessary, because:
      - we relay on logrus interface so much that moving to another logging
        library will be not so simple as switching the import name;
      - we're totally not consistent in the alias usage which makes the code
        even more messy.
      
      Three GitLab Runner maintainers agreeded hat there is no reason to use
      the aliasing and that we should just use `logrus` everywhere.
      
      But no action was don since then. The cleanup was left for a future.
      
      Unfortunately, because GitLab Runner is one of our biggest projects in
      Go, for some people it becomes a source of suggestions of how certain
      things should be handled. For example here is a discussion in a new
      project that creates a go-based tool for our Serverless integration:
      
      gitlabktl!9 (comment 152472275)
      
      The most important statement is:
      
      > perhaps we could leave it as is since it is how we are exposing
        logrus in the runner project
      
      Because we already know that it should be changed and others start to
      look on Runner's code to find good patterns, let's finally cleanup
      the `log` aliasing mess.
      d9e9d81c
  4. 16 Mar, 2019 4 commits
  5. 13 Mar, 2019 1 commit
  6. 11 Mar, 2019 1 commit
    • Tomasz Maczukin's avatar
      Restore availability of pprof in the debug server · 0cb2512f
      Tomasz Maczukin authored
      With CI Web Terminal initial implementation
      (!934)
      we've changed the way how the debug server is started.
      
      It can be seen at !934 (diffs)
      
      ```diff
      +		mux := http.NewServeMux()
      +
      		go func() {
      -			log.Fatalln(http.Serve(listener, nil))
      +			log.Fatalln(http.Serve(listener, mux))
      		}()
      ```
      
      Instead of relaying on the `http.DefaultServeMux` (which is used when
      `http.Serve(listener, nil)` is called), we're creating our own ServeMux
      which next is used for handling requests.
      
      Unfortunately this breaks automatic registration of pprof handlers,
      which in `net/http/pprof`'s `init()` are using `http.Handle()`, which
      registers the handlers in `http.DefaultServeMux`.
      
      This commit adds an explicit registration of pprof handlers to the
      `mux` ServeMux created by us. This will restore the functionality
      that we had present before version 11.3.0.
      0cb2512f
  7. 06 Mar, 2019 1 commit
    • Kamil Trzciński's avatar
      Add ability to mask variables. · 4bf5c2fd
      Kamil Trzciński authored
      This makes variables to be allowed to be `masked: true`.
      The masked values will be replaced with `[MASKED]`.
      The masking is done in-line, thus we delay sending trace
      if the content is partial match for masked output.
      4bf5c2fd
  8. 05 Mar, 2019 1 commit
    • Steve Azzopardi's avatar
      Update TestCacheInit to dir instead of file · 837d5c00
      Steve Azzopardi authored
      Windows doesn't seem to support `+x` for files, ending up with
      permissions looking like `-rw-rw-rw-` which is not `0777`, which leads
      in the test to fail.
      
      The main idea of the `cache-init` is to change permissions for
      directories not files so we should update the test to reflect that.
      837d5c00
  9. 25 Feb, 2019 1 commit
    • Steve Azzopardi's avatar
      Port cache bash script to Go for helper image · 617995a2
      Steve Azzopardi authored
      `gitlab-runner-cache` is being used to change the permissions, port
      this script to Go so that it is cross-platform.
      
      The bash script loops through the paths but separating them with
      spaces, which will not work for Windows since it is a lot more common to
      have a directory with spaces. Looking at the usage of the script we
      always send 1 path so the loop was a bit redundant.
      
      For now do not use the Go command since changing it will result into a
      breaking change. This will be done behind a feature flag which will done
      in a feature MR.
      
      #3755
      617995a2
  10. 23 Feb, 2019 1 commit
  11. 17 Feb, 2019 1 commit
  12. 15 Feb, 2019 1 commit
    • Steve Azzopardi's avatar
      Add service wait script in Go · 102f30b0
      Steve Azzopardi authored
      `gitlab-runner-service` is a bash script inside of the helper image that
      runs to check if a specific host/port of service is open. This is
      written in bash currently, which does not run on windows. With support
      for windows coming we need to make this cross platform.
      
      Create a new command `health-check` for the `gitlab-runner-helper` CLI
      which has the same logic that will be used only for windows containers
      not to have any breaking changes for the current Linux containers
      
      #3755
      102f30b0
  13. 23 Jan, 2019 3 commits
  14. 16 Jan, 2019 1 commit
  15. 01 Nov, 2018 1 commit
  16. 22 Oct, 2018 1 commit
  17. 16 Oct, 2018 2 commits
  18. 15 Oct, 2018 1 commit
  19. 03 Oct, 2018 6 commits
  20. 26 Sep, 2018 3 commits
  21. 20 Sep, 2018 1 commit
  22. 13 Sep, 2018 3 commits
  23. 11 Sep, 2018 1 commit