1. 21 Mar, 2019 1 commit
    • Tomasz Maczukin's avatar
      Remove unnecessary log alias for logrus inport · d9e9d81c
      Tomasz Maczukin authored
      Some time ago [we had a discussion](gitlab-org/gitlab-runner!934 (comment 91891281))
      about why we're aliasing some of the imports of `github.com/sirupsen/logrus`
      package with a `log` alias.
      
      At that moment we've been doing that in 17 from 68 cases when logrus
      was imported in Runners codebase.
      
      The conclusion was this aliasing is unnecessary, because:
      - we relay on logrus interface so much that moving to another logging
        library will be not so simple as switching the import name;
      - we're totally not consistent in the alias usage which makes the code
        even more messy.
      
      Three GitLab Runner maintainers agreeded hat there is no reason to use
      the aliasing and that we should just use `logrus` everywhere.
      
      But no action was don since then. The cleanup was left for a future.
      
      Unfortunately, because GitLab Runner is one of our biggest projects in
      Go, for some people it becomes a source of suggestions of how certain
      things should be handled. For example here is a discussion in a new
      project that creates a go-based tool for our Serverless integration:
      
      gitlab-org/gitlabktl!9 (comment 152472275)
      
      The most important statement is:
      
      > perhaps we could leave it as is since it is how we are exposing
        logrus in the runner project
      
      Because we already know that it should be changed and others start to
      look on Runner's code to find good patterns, let's finally cleanup
      the `log` aliasing mess.
      d9e9d81c
  2. 23 Jan, 2019 1 commit
    • Steve Azzopardi's avatar
      Update ExecutorProvider interface signature · e465b0aa
      Steve Azzopardi authored
      Update the `Release` signature of the `ExecutorProvider` interface.
      Returning an error when releasing a resource is not actionable, and all
      of the implementations of `ExecutorProvider` do not return an error.
      e465b0aa
  3. 31 Oct, 2018 2 commits
  4. 07 Aug, 2018 4 commits
  5. 20 Jul, 2018 1 commit
  6. 23 Feb, 2018 1 commit
  7. 20 Apr, 2017 4 commits
  8. 14 Apr, 2017 1 commit
  9. 03 Dec, 2016 1 commit
    • Kamil Trzciński's avatar
      Add a multiple prometheus metrics: · 857d72e5
      Kamil Trzciński authored
      Metrics from Machine Provider (Auto-scaling):
      - ci_machines_provider{state=acquired|creating|idel|used|removing} - current number of machines in given state,
      - ci_machines{type=created|used|removed} - total number of machines,
      
      Metrics from Builds with breakdown on stage and runtime state:
      - ci_runner_builds{state=pending|running|finished|canceled|terminated|timedout, stage=prepare_script|build_script|after_script|archive_cache|upload_artifacts} - current number of builds in given state
      857d72e5
  10. 06 Jul, 2016 1 commit
    • Kamil Trzciński's avatar
      Improve logging · a32e645c
      Kamil Trzciński authored
      - Introduce BuildError to generate soft failure on build error and generate hard failure on system error
      - Use WithField instead of pushing data as arguments of most of logging functions
      - Introduce BuildLogger which removes logging functionality from AbstractExecutor
      - Use BuildLogger and write notice message as early as possible
      - Remove finish notice/error from AbstractExecutor
      - Sending and appending build trace is now debug message by default
      a32e645c
  11. 06 Jun, 2016 1 commit
    • Kamil Trzciński's avatar
      Refactor script generation to make it fully on-demand · 62ebf0c8
      Kamil Trzciński authored
      - Rename `ShellScript` to `ShellConfiguration` and remove all generated scripts
      - Introduce `ShellScriptType` with different types of scripts
      - Introduce `GetConfiguration` and `GenerateScript` for `Shell` interface
      - Change `ShellScript` to `Shell` of `Executor`
      - Remove `GenerateScript` from shells, instead provide a generic method with accepts `ShellScriptType`
      - Introduce `executeShellScript` for `Build`, method which is responsible for generating and executing a shell script
      62ebf0c8
  12. 04 May, 2016 2 commits
  13. 08 Feb, 2016 2 commits
  14. 07 Feb, 2016 1 commit
  15. 18 Oct, 2015 2 commits
  16. 14 Jul, 2015 4 commits
  17. 11 Jul, 2015 1 commit
  18. 20 Mar, 2015 1 commit
  19. 16 Mar, 2015 1 commit
  20. 11 Mar, 2015 1 commit
  21. 12 Feb, 2015 2 commits