1. 23 Apr, 2019 1 commit
    • Steve Azzopardi's avatar
      Refactor helper image revision check · 2fda3dcd
      Steve Azzopardi authored
      Both Docker and Kubernetes executor are checking what kind of revision
      is being used so it can be used to pull in the right helper image,
      extract that logic to `helperImage` package.
      2fda3dcd
  2. 22 Apr, 2019 3 commits
    • Steve Azzopardi's avatar
      Refactor helpers/docker/helperimage package · afa41f0b
      Steve Azzopardi authored
      The helper image is being used for both Kubernetes and Docker executor.
      But the code does not represent this, instead it duplicates the logic,
      such as creating the Linux tag and the name of the image.
      
      Refactor the helperimage package so that it can be used for both, by
      removing specific structs from the docker API, by defining helperimage
      own Config struct.
      
      The need for the refactor is for
      gitlab-org/gitlab-runner!1243, because
      we need to define different commands to run on the helper image, which
      is located in `common/container.go` which needs to change depending on
      the OS Type of docker, and we can't change it before we change how
      Kubernetes uses the helper image.
      afa41f0b
    • Steve Azzopardi's avatar
      Update documentation for legacy feature flags · ca548565
      Steve Azzopardi authored
      The feature flags disables the new code path not enabling it, the new
      code path is enabled by default.
      ca548565
    • Steve Azzopardi's avatar
      Format flags_test.go · 23c0be5e
      Steve Azzopardi authored
      Remove some whitespace and order struct initialization
      23c0be5e
  3. 19 Apr, 2019 3 commits
  4. 11 Apr, 2019 1 commit
  5. 08 Apr, 2019 1 commit
  6. 02 Apr, 2019 1 commit
  7. 21 Mar, 2019 3 commits
    • Tomasz Maczukin's avatar
      Remove unnecessary log alias for logrus inport · d9e9d81c
      Tomasz Maczukin authored
      Some time ago [we had a discussion](!934 (comment 91891281))
      about why we're aliasing some of the imports of `github.com/sirupsen/logrus`
      package with a `log` alias.
      
      At that moment we've been doing that in 17 from 68 cases when logrus
      was imported in Runners codebase.
      
      The conclusion was this aliasing is unnecessary, because:
      - we relay on logrus interface so much that moving to another logging
        library will be not so simple as switching the import name;
      - we're totally not consistent in the alias usage which makes the code
        even more messy.
      
      Three GitLab Runner maintainers agreeded hat there is no reason to use
      the aliasing and that we should just use `logrus` everywhere.
      
      But no action was don since then. The cleanup was left for a future.
      
      Unfortunately, because GitLab Runner is one of our biggest projects in
      Go, for some people it becomes a source of suggestions of how certain
      things should be handled. For example here is a discussion in a new
      project that creates a go-based tool for our Serverless integration:
      
      gitlabktl!9 (comment 152472275)
      
      The most important statement is:
      
      > perhaps we could leave it as is since it is how we are exposing
        logrus in the runner project
      
      Because we already know that it should be changed and others start to
      look on Runner's code to find good patterns, let's finally cleanup
      the `log` aliasing mess.
      d9e9d81c
    • Steve Azzopardi's avatar
      Refactor test not to be runtime dependent · d0e2afb6
      Steve Azzopardi authored
      We are checking if the image tag is `x86_64-xxx` for any kind of runtime
      the test is running, which is not true because if the test is run on arm
      it would fail.
      d0e2afb6
    • Steve Azzopardi's avatar
      Check for windows server version with boundaries · 7118bb81
      Steve Azzopardi authored
      One day we can end up with a windows server version of `Windows Server
      2019 Datacenter Evaluation Version 1809 (OS Build 18033.316)` which
      would end up picking the wrong image since it would match the wrong
      version.
      
      regexp was not used to the sake of performance and to make thins a bit
      simplier/more readable.
      7118bb81
  8. 20 Mar, 2019 1 commit
  9. 06 Mar, 2019 1 commit
    • Kamil Trzciński's avatar
      Add ability to mask variables. · 4bf5c2fd
      Kamil Trzciński authored
      This makes variables to be allowed to be `masked: true`.
      The masked values will be replaced with `[MASKED]`.
      The masking is done in-line, thus we delay sending trace
      if the content is partial match for masked output.
      4bf5c2fd
  10. 11 Feb, 2019 1 commit
  11. 08 Feb, 2019 2 commits
  12. 21 Jan, 2019 1 commit
    • Steve Azzopardi's avatar
      Remove `ContainerWait` from docker client · 906661a0
      Steve Azzopardi authored
      `ContainerWait` is not being used anywhere at this point, there are
      plans to use it as a replacement for gitlab-runner `waitForContainer`
      func over at  #3918,
      but in the mean time it should be removed since it's dead code.
      906661a0
  13. 18 Jan, 2019 1 commit
    • Steve Azzopardi's avatar
      Consolidate docker API version definition · 84ad1a8f
      Steve Azzopardi authored
      Refactor to only have 1 definition of the API version, since
      there are two places that the API version is defined.
      
      Update behavior of `docker.New` to where, if empty string is specified
      the default version would be used.
      84ad1a8f
  14. 15 Jan, 2019 2 commits
  15. 22 Oct, 2018 1 commit
  16. 05 Oct, 2018 1 commit
    • Steve Azzopardi's avatar
      Add web terminal for docker executor · c45fc343
      Steve Azzopardi authored
      Use reflect.DeepEqual for session.closeTerminalConn since the struct
      might have slices which are not comparable.
      
      Make the docker executor implement the `session.Conn` &
      `session.InteractiveTerminal` interface to support interactive web
      terminals.
      
      Update `gitlab-terminal` package to version to support docker stream.
      c45fc343
  17. 03 Oct, 2018 4 commits
  18. 26 Sep, 2018 1 commit
  19. 21 Sep, 2018 1 commit
  20. 06 Sep, 2018 1 commit
  21. 14 Aug, 2018 1 commit
  22. 09 Aug, 2018 1 commit
  23. 07 Aug, 2018 2 commits
  24. 31 Jul, 2018 1 commit
  25. 30 Jul, 2018 2 commits
  26. 12 Jul, 2018 1 commit
  27. 10 Jul, 2018 1 commit