Skip to content
Unverified Commit b3b26bcc authored by Tomasz Maczukin's avatar Tomasz Maczukin 💬 Committed by Steve Azzopardi
Browse files

Merge branch '3896-update-docker-executor-default-shell' into 'master' 

Add powershell support for Docker Executor

Closes #3896

See merge request gitlab-org/gitlab-runner!1243
parent 862af32e
Show whitespace changes
Inline Side-by-side
  • Jan Wilmans @janwilmans ·

    What about 1903 support? https://docs.microsoft.com/en-us/windows/whats-new/whats-new-windows-10-version-1903

    I'm getting this:

    Running with gitlab-runner 11.11.2 (ac2a293c)
  on dev-windows (a virtual windows 10 machine called BT1-VM-WIN10-Gitlab71 on vSphere) 7PhLzoGk
ERROR: Preparation failed: could not determine windows version
Will be retried in 3s ...
ERROR: Preparation failed: could not determine windows version
Will be retried in 3s ...
ERROR: Preparation failed: could not determine windows version
Will be retried in 3s ...
ERROR: Job failed (system failure): could not determine windows version

    which I think might be because that version is unknown to gitlab? could we make it so higher versions are assumed to work like to the highest know version? I think that has the best chance of success?

    Edited by Jan Wilmans
  • Steve Xuereb @sxuereb

    mentioned in issue #4396 (closed)

     ·

    mentioned in issue #4396 (closed)

    Toggle commit list
  • Steve Xuereb @sxuereb ·
    Maintainer

    Thanks for reporting it @janwilmans I've opened an issue #4396 (closed) so that we can track, feel free to upvote it!

  • Jan Wilmans @janwilmans ·

    Thanks, much appreciated!

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment