Commit a6f8ca8d authored by Tomasz Maczukin's avatar Tomasz Maczukin 🌴

Merge branch 'failure-means-failure' into 'master'

Fail build in case of code_quality errors

See merge request gitlab-org/gitlab-runner!986
parents a2c4246a 3634655e
Pipeline #27865763 passed with stages
in 41 minutes and 48 seconds
......@@ -466,3 +466,17 @@ stable docker images:
environment:
name: stable/docker_images
url: https://hub.docker.com/r/gitlab/gitlab-runner/tags/
static QA:
<<: *except_docs
stage: release
image: alpine:3.7
cache: {}
dependencies:
- code_quality
script: |
if [ "$(cat gl-code-quality-report.json)" != "[]" ] ; then
apk add -U --no-cache jq > /dev/null
jq -C . gl-code-quality-report.json
exit 1
fi
......@@ -41,4 +41,3 @@ func TestTracePatchEmptyPatch(t *testing.T) {
assert.Empty(t, tp.Patch())
}
......@@ -323,7 +323,7 @@ func TestFinalUpdateWithTrace(t *testing.T) {
b := newJobTrace(net, jobConfig, jobCredentials)
finalUpdateMatcher := mock.MatchedBy(func(jobInfo common.UpdateJobInfo) bool {
return *jobInfo.Trace == (traceMessage+traceMessage)
return *jobInfo.Trace == (traceMessage + traceMessage)
})
net.On("PatchTrace", jobConfig, jobCredentials, mock.Anything).Return(common.UpdateSucceeded).Once().Run(func(_ mock.Arguments) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment