Commit 337bf41c authored by Tomasz Maczukin's avatar Tomasz Maczukin

Merge branch 'follow-up-for-1313' into 'master'

Update feature flag documentation

See merge request !1326
parents 46b8b703 ca548565
Pipeline #57921832 failed with stages
in 59 minutes and 34 seconds
......@@ -39,6 +39,6 @@ The flags are defined in `./helpers/feature_flags/flags.go` file.
| `FF_K8S_USE_ENTRYPOINT_OVER_COMMAND` | `true` | ✓ | 12.0 | Enables [the fix](https://gitlab.com/gitlab-org/gitlab-runner/merge_requests/1010) for entrypoint configuration when `kubernetes` executor is used |
| `FF_DOCKER_HELPER_IMAGE_V2` | `false` | ✓ | 12.0 | Enable the helper image to use the new commands when [helper_image](https://docs.gitlab.com/runner/configuration/advanced-configuration.html#the-runnersdocker-section) is specified. This will start using the new API that will be used in 12.0 and stop showing the warning message in the build log |
| `FF_CMD_DISABLE_DELAYED_ERROR_LEVEL_EXPANSION` | `false` | ✗ | | Disables [EnableDelayedExpansion](https://ss64.com/nt/delayedexpansion.html) for error checking for when using [Window Batch](https://docs.gitlab.com/runner/shells/#windows-batch) shell |
| `FF_USE_LEGACY_GIT_CLEAN_STRATEGY` | `false` | ✓ | 12.0 | Enables the new strategy for `git clean` that moves the clean operation after checkout and enables support for `GIT_CLEAN_FLAGS` |
| `FF_USE_LEGACY_BUILDS_DIR_FOR_DOCKER` | `false` | ✓ | 13.0 | Enables the new strategy for Docker executor to cache the content of `/builds` directory instead of `/builds/group-org` |
| `FF_USE_LEGACY_GIT_CLEAN_STRATEGY` | `false` | ✓ | 12.0 | Disables the new strategy for `git clean` that moves the clean operation after checkout and enables support for `GIT_CLEAN_FLAGS` |
| `FF_USE_LEGACY_BUILDS_DIR_FOR_DOCKER` | `false` | ✓ | 13.0 | Disables the new strategy for Docker executor to cache the content of `/builds` directory instead of `/builds/group-org` |
<!-- feature_flags_list_end -->
......@@ -52,14 +52,14 @@ var flags = []FeatureFlag{
DefaultValue: "false",
Deprecated: true,
ToBeRemovedWith: "12.0",
Description: "Enables the new strategy for `git clean` that moves the clean operation after checkout and enables support for `GIT_CLEAN_FLAGS`",
Description: "Disables the new strategy for `git clean` that moves the clean operation after checkout and enables support for `GIT_CLEAN_FLAGS`",
},
{
Name: UseLegacyBuildsDirForDocker,
DefaultValue: "false",
Deprecated: true,
ToBeRemovedWith: "13.0",
Description: "Enables the new strategy for Docker executor to cache the content of `/builds` directory instead of `/builds/group-org`",
Description: "Disables the new strategy for Docker executor to cache the content of `/builds` directory instead of `/builds/group-org`",
},
}
......
......@@ -41,23 +41,21 @@ func TestIsOn(t *testing.T) {
expectedError: `strconv.ParseBool: parsing "a": invalid syntax`,
},
"true value": {
expectedResult: true,
testValue: "1",
expectedResult: true,
},
"false value": {
expectedResult: false,
testValue: "f",
expectedResult: false,
},
}
for testName, testCase := range testCases {
t.Run(testName, func(t *testing.T) {
result, err := IsOn(testCase.testValue)
assert.Equal(t, testCase.expectedResult, result)
if testCase.expectedError != "" {
assert.EqualError(t, err, testCase.expectedError)
} else {
assert.NoError(t, err)
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment