Consider all docker image pull errors as a script failure rather than a system failure (#28075) · Issues · GitLab.org / gitlab-runner · GitLab

Consider all docker image pull errors as a script failure rather than a system failure

## Overview In https://gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/2995 we stoped considering `docker pull` failures, however we only do this for [certain type of errors](https://gitlab.com/gitlab-org/gitlab-runner/-/blame/d7868c2bd846b86e8859a920784b71a065d866a7/executors/docker/internal/pull/manager.go#L206) we should return a Build failure for all errors from pull. For example, we still see the following failures in production: ``` Job failed (system failure): failed to pull image "xxxxxxxx:ff3e18f6" with specified policies [always]: Error response from daemon: Get https://xxxx.xxxxx.amazonaws.com/v2/sidekiqs/manifests/ff3e18f6: no basic auth credentials (manager.go:205:0s) ````

issue