Add Kubernetes pod label sanitization

What does this MR do?

Adding sanitation for kubernetes labels to avoid issues with non conformative variables. executorkubernetes

Why was this MR needed?

Currently the user needs to be careful when declaring variables in the Kubernetes labels. Such labels may not conform with the restrictions for Labels in Kubernetes which will result in a failing pipeline.

What's the best way to test this MR?

Add the following configuration to a kubernetes executor:

        [runners.kubernetes.pod_labels]
        forbidden_label = "@Hello world this value is not valid--"
        job_name = "${CI_JOB_NAME}"

The job_name can illustrate one of the possible usages.

What are the relevant issue numbers?

Closes #4565 (closed)

executors/kubernetes/util.go

@@ -346,17 +346,23 @@ func buildCapabilities(enabled map[string]bool) *api.Capabilities {
 	return capabilities
 }
 
-
 // Sanitize labels to match Kubernetes restrictions from https://kubernetes.io/
 // /docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set
 func sanitizeLabel(value string) string {
-    if len(value) > 63 {
-        value = value[:63]
-    }
+	if len(value) > 63 {
+		value = value[:63]
+	}
 
 	re := regexp.MustCompile(`[^A-Za-z0-9-._ ]`)
-    standardized := re.ReplaceAllLiteralString(value, "")
+	standardized := re.ReplaceAllLiteralString(value, "")
+
+	final := strings.ReplaceAll(standardized, " ", "-")
+
+	// Logic of replacing start and end chars if not alphanumerical
+	beg := regexp.MustCompile(`^[^A-Za-z0-9]+`)
+	end := regexp.MustCompile(`[^A-Za-z0-9]+$`)
+	final = beg.ReplaceAllLiteralString(final, "")
+	final = end.ReplaceAllLiteralString(final, "")
 
-    final := strings.Replace(standardized, " ", "-", -1)
-    return final
+	return final
 }