Skip to content

Fix default cache volume docker-windows register

What does this MR do?

Fix default cache volume docker-windows register

Why was this MR needed?

When the user specifies docker-windows /cache is still used as a default value, which is never correct in any cache. The default cache volume for docker-windows needs to be c:\\cache.

With this, there is only one limitation, the detection of c:\\cache when the user specified volumes on registration. With the following specification c:\\cache:c:\\User\\ContainerAdministrator\\cache we fail to add the c:\\cache to be used as a cache directory and the reason for this is because a simple string match is being done. For Linux, it's easier since we can split the string with : but for Windows : is part of the volume mounting. To properly support this scenario we require to expose the volume parser from Docker which is not ideal.

closes #3915 (closed)

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

Closes #3915 (closed)

Edited by Steve Xuereb

Merge request reports