Change commander interface
The following discussion from !1743 (merged) should be addressed:
-
@ggeorgiev_ started a discussion: I don't think it should be in this particular MR. But exposing
os.Process
through theCommander
is bothering me. Do you think we could encapsulate it inside theCommander
? Even now, we only use theProcess
method only to check if it'snil
and get thePid
. We can do that by exposing aProcessPid() (int, error)
method on the interface. Then, we can also set theprocessGroup
in the constructor and be sure it won't be changed by outside callers.But this is just an idea. If you don't think it's worth changing in the future feel free to ignore this comment.