tag gitlab-runner-helper images with CI_RUNNER_VERSION
Description
When attempting to mirror images to use gitlab-runner in an airgapped environment, it is a burden to have to inspect the Git revision of the gitlab-runner binary in order to figure out which gitlab-runner-helper image to mirror so it is available offline. For the gitlab-runner image itself, it is tagged with CI_RUNNER_VERSION and the image can be determined simply by inspecting the Helm chart. The gitlab-runner-helper image should follow the same pattern.
My values overrides for the chart use this:
image: 'docker.knack.works/gitlab/gitlab-runner:alpine-v12.1.0'
runners:
helpers:
image: 'docker.knack.works/gitlab/gitlab-runner-helper:x86_64-${CI_RUNNER_REVISION}'But there is no way for me to determine the value of CI_RUNNER_REVISION from the Helm chart and need to execute a container instead:
docker run -it --rm docker.knack.works/gitlab/gitlab-runner:alpine-v12.1.0 --version | awk -F: '/Git revision/ { print $2 }'Proposal
The gitlab-runner-helper image should also be tagged with CI_RUNNER_VERSION. This would simplify both the mirroring of the images and the values set for the Helm chart because the gitlab-runner-helper tag is based on a known value (e.g., v12.1.0).
Alternatively, the value of CI_RUNNER_REVISION could be included in the Helm chart so it could be referenced, but that seems like a far worse solution.